Show errors, plus code refactoring.#22
Closed
dkosmari wants to merge 2 commits into
Closed
Conversation
added 2 commits
March 13, 2026 18:21
- Some refactoring to reduce code duplication and explicit error handling.
Contributor
|
Please reopen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users will download a bunch of images off places like Discord and Reddit, which are known for converting PNG images to WEBP, whilst keeping the
.pngresource name. So users end up downloading a WEBP image named.png.This adds an error reporting screen, when an image fails to load, instead of just silently falling back to another image. The error screen stays up for 15 seconds, which should be enough for the user to write down the name of the "bad" image, and either delete it, or rename it properly.
I also went ahead and did some refactoring to remove code duplication when creating the texture, and turned the explicit error handling with RAII handling. The image loading functions now return a message as the error in a
std::expectedobject.