Implemented button suppression when a combo is activated.#12
Open
dkosmari wants to merge 6 commits into
Open
Conversation
dkosmari
force-pushed
the
button-suppression
branch
from
36fa78a to
e3b5e87
Compare
added 2 commits
May 9, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid performing game actions while activating a combo, this PR adds button suppression.
Whenever a combo is activated, the buttons flagged as triggered in that
*PADRead()call will be disabled. So the game never sees the last set of buttons that activated a combo. When each disabled button is released, it's enabled again.As an example, the screenshot plugin uses TV + LEFT by default. If the game reacts to the LEFT button, taking screenshots can interfere with normal gameplay. With this PR, if the user holds the TV button, and then presses LEFT, the game will not see the LEFT button being pressed.