Skip to content

ci(bench): build tulipy with -Wno-error=incompatible-pointer-types - #505

Merged
kingchenc merged 1 commit into
mainfrom
fix/bench-tulipy-gcc14
Nov 2, 2026
Merged

kingchenc merged 1 commit into
mainfrom
fix/bench-tulipy-gcc14

Conversation

@kingchenc

Copy link
Copy Markdown
Collaborator

The scheduled cross-library benchmark has failed since 2026-11-01: ubuntu-latest moved from ubuntu-24.04 to ubuntu-26.04 between the last green run (2026-10-31, on a8bccd2) and the first red one (2026-11-01, on 90ca39c), and tulipy no longer builds:

tulipy/lib/__init__.c: error: passing argument 2 of '__pyx_v_self->info->indicator' from incompatible pointer type [-Wincompatible-pointer-types]
ERROR: Failed building wheel for tulipy

tulipy 0.4.0 is published only as an sdist, so the job compiles it. Its Cython code passes TI_REAL ** (c_inputs) to ti_indicator_function, which takes TI_REAL const *const *inputs. That is a const-only difference, which C does not convert implicitly. The function only reads its inputs, so nothing is wrong at runtime. GCC 14 turned -Wincompatible-pointer-types into an error by default, and 26.04's compiler has that default.

The install step now sets CFLAGS=-Wno-error=incompatible-pointer-types, so the diagnostic goes back to being a warning. Checked by building tulipy 0.4.0 with GCC 13 plus -Werror=incompatible-pointer-types (the GCC 14 default): it fails at tulipy/lib/__init__.c the same way. With the flag added, it builds, and tulipy.sma returns the expected values.

CI-only change. The benchmark itself runs on its schedule, so it confirms the fix after the merge.

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kingchenc
kingchenc merged commit 86a57b9 into main Nov 2, 2026
68 checks passed
@kingchenc
kingchenc deleted the fix/bench-tulipy-gcc14 branch November 2, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant