Repository navigation
ci(bench): build tulipy with -Wno-error=incompatible-pointer-types - #505
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled cross-library benchmark has failed since 2026-11-01:
ubuntu-latestmoved from ubuntu-24.04 to ubuntu-26.04 between the last green run (2026-10-31, on a8bccd2) and the first red one (2026-11-01, on 90ca39c), andtulipyno longer builds:tulipy 0.4.0 is published only as an sdist, so the job compiles it. Its Cython code passes
TI_REAL **(c_inputs) toti_indicator_function, which takesTI_REAL const *const *inputs. That is a const-only difference, which C does not convert implicitly. The function only reads its inputs, so nothing is wrong at runtime. GCC 14 turned-Wincompatible-pointer-typesinto an error by default, and 26.04's compiler has that default.The install step now sets
CFLAGS=-Wno-error=incompatible-pointer-types, so the diagnostic goes back to being a warning. Checked by building tulipy 0.4.0 with GCC 13 plus-Werror=incompatible-pointer-types(the GCC 14 default): it fails attulipy/lib/__init__.cthe same way. With the flag added, it builds, andtulipy.smareturns the expected values.CI-only change. The benchmark itself runs on its schedule, so it confirms the fix after the merge.