Repository navigation
ci: point osv-scanner at the Python lockfiles it was silently skipping - #141
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blind spot
OSV-Scanner discovers lockfiles by filename. None of
ci-dev-py3.txt,ci-dev-py39.txtmatches a pattern it recognises, so--recursivewalked past every hash-locked file in.github/requirements/, and the Python CI dependencies were never scanned. A file renamed torequirements-*.txtin the same directory is picked up, so it is the filename and not the hidden.githubdirectory.The files keep their names, which Dependabot, the lockfile refresh and the family use, and the format is stated explicitly instead:
wickra-lib/wickra-exchange#167 made the same change. wickra-lib/wickra#506 does it for
wickra. The step's comment says a new file there needs a line here.Verified
The osv-scanner command was taken from the parsed workflow and run on a clean export of this branch:
No issues found), exit code 0;