Repository navigation
Merged
Conversation
…y platform package
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
cd bindings/node && npm installin the workflows becomesnpm ci(4 sites in.github/workflows/ci.yml,.github/workflows/release.yml), so CI and the release install exactly the lockfile and refuse one that disagrees with the manifest.The comments justified
npm installby the six per-platformoptionalDependencies: they were not on the registry yet, so the lock could not name them andnpm ciwould reject it withEUSAGE ... Missing: <platform package>@ from lock file. That no longer holds. The releases published them, andbindings/node/package-lock.jsonnow has an entry for all six, at the versionpackage.jsonnames.A release bump moves those lock entries to the new version before this run publishes it. wickra-backtest shows that
npm ciaccepts that: it switched tonpm ciin both workflows on 2026-08-28 and has released eleven times since (v0.1.1 to v0.2.1). At v0.2.1 its lock named the unpublished 0.2.1 platform packages, andnpm ciinstalled cleanly in the Node build and the npm publish jobs.The Node jobs of this pull request run
npm ciagainst this lock on Node 22 and 24 on all three operating systems. That covers the stricter lock validation in Node 24's npm that an earlier attempt ran into while the entries were missing.Closes the Scorecard PinnedDependencies alert #133 ("npmCommand not pinned by hash").