Repository navigation
ci(release): use setup-java's *-env-var inputs - #163
Merged
Merged
Conversation
setup-java deprecated server-username, server-password and gpg-passphrase in favour of server-username-env-var, server-password-env-var and gpg-passphrase-env-var, and warns on every release run that still uses them. The old names are aliases with the same meaning -- the name of the environment variable the Maven deploy step sets -- so the values stay as they are and settings.xml comes out identical.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/setup-javadeprecated three inputs of the Maven Central step inrelease.yml, and every release run that still uses them carries a warning annotation:server-usernameserver-username-env-varserver-passwordserver-password-env-vargpg-passphrasegpg-passphrase-env-varThe
action.ymlof both pinned releases (v6.0.1 and v6.1.0) declares the old names as "Deprecated alias for" the new ones. Both take the name of an environment variable, not a secret, so the values (CENTRAL_USERNAME,CENTRAL_PASSWORD,GPG_PASSPHRASE) stay as they are and the generatedsettings.xmlis identical.release.ymlruns on tag pushes only, so this PR's checks cover it through actionlint and zizmor; the next release run is where the warnings disappear.