Skip to content

ci: point osv-scanner at the Python lockfiles it was silently skipping - #106

Merged
kingchenc merged 1 commit into
mainfrom
ci/osv-requirements
Nov 2, 2026
Merged

kingchenc merged 1 commit into
mainfrom
ci/osv-requirements

Conversation

@kingchenc

Copy link
Copy Markdown
Contributor

The blind spot

OSV-Scanner discovers lockfiles by filename. None of ci-dev-py3.txt, ci-dev-py39.txt, manifest.txt matches a pattern it recognises, so --recursive walked past every hash-locked file in .github/requirements/, and the Python CI dependencies were never scanned. A file renamed to requirements-*.txt in the same directory is picked up, so it is the filename and not the hidden .github directory.

The files keep their names, which Dependabot, the lockfile refresh and the family use, and the format is stated explicitly instead:

--lockfile=requirements.txt:.github/requirements/ci-dev-py3.txt
--lockfile=requirements.txt:.github/requirements/ci-dev-py39.txt
--lockfile=requirements.txt:.github/requirements/manifest.txt

wickra-lib/wickra-exchange#167 made the same change. wickra-lib/wickra#506 does it for wickra. The step's comment says a new file there needs a line here.

Verified

The osv-scanner command was taken from the parsed workflow and run on a clean export of this branch:

  • every file above is scanned;
  • no finding (No issues found), exit code 0;
  • no unused ignores;
  • actionlint is clean.

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@kingchenc
kingchenc merged commit f9b231e into main Nov 2, 2026
174 of 178 checks passed
@kingchenc
kingchenc deleted the ci/osv-requirements branch November 2, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant