Conversation
* Replace IPv4 parser internals with regex-free scanners Port the strict four-part digit scanner and loose inet_aton digit/base scanner in-tree so IPv4.isValid / parse / parseCIDR / isValidFourPartDecimal no longer use RegExp. Keep the public API and IPv6 transitional ipv4Part pattern unchanged for a small upstreamable diff. * Harden parseIntAutoDigits against empty digit spans Throw when start >= end, matching @kleinron/ipv4, so a caller bug cannot silently return 0 from an empty range. --------- Co-authored-by: Ron Klein <1203923+kleinron@users.noreply.github.com>
Owner
|
Not interested in maintaining this, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In-tree IPv4 parser guts swap (MIT): regex-free hand scanners for strict four-part + loose/
inet_aton+ CIDR split. No new deps; no@kleinron/ipv4import. PublicIPv4API and accept set unchanged; IPv6 transitional regexes that reuseipv4Partstay.Motivation / benches
Microbench tables below were measured on
@kleinron/ipv4using the same algorithms (not timed on this fork). Please re-bench here if useful.Full tables: https://github.com/kleinron/ipv4/blob/main/bench/RESULTS.md
Highlight:
isValidFourPartDecimalisValidFourPartDecimalmixed / accept / rejectisValidloose mixed / accept / rejectparsestrict acceptparseloose acceptparse/parseCIDRreject–mixedparseCIDRacceptTest plan