Migrate ipaddr.js to ESM only (second try) - #211
Merged
Merged
Conversation
hahah 3.4.0 would not be the next major version after 2.4.0 regardless, but main has 2.5.0, so both are wrong
Contributor
Author
|
@whitequark if you've got time to review 👋 |
whitequark
reviewed
Aug 18, 2026
| .idea | ||
| node_modules | ||
| package-lock.json | ||
| .DS_Store No newline at end of file |
Owner
There was a problem hiding this comment.
Please don't add these to per-project gitignore files; instead use a global one (git config --global core.excludesFile) that covers every project on your machine.
whitequark
reviewed
Aug 18, 2026
whitequark
left a comment
whitequark
left a comment
Owner
There was a problem hiding this comment.
I'm happy about the code changes (there's very little actual diff, it's almost entirely whitespace, which is as it should be), please squash the commits and I'll merge it!
Owner
|
I forgot I can just do it myself. Merged, thanks! |
Contributor
Author
|
awesome! ping me when this releases if you don't mind 💜 excited to get this in use |
Contributor
Author
|
why delete the DS_Store gitignore line? i'm curious? |
Owner
I left an inline comment with an explanation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework of #193
Technically a third try, since I didn't rebase until I opened the draft PR and saw the conflicts 😭
The commits are much cleaner and linear now though.