Skip to content

enhance(types): Narrow down type definition of subnetMatch #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whitequark merged 4 commits into from
Aug 19, 2026
+3 −3
Merged

enhance(types): Narrow down type definition of subnetMatch #187

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4e0f4d
enhance(types): Narrow down type definition of subnetMatch
kakkokari-gtyih Jul 17, 2025
6c1dfc7
fix
kakkokari-gtyih Jul 17, 2025
061c9ae
Merge branch 'main' into enh-186
kakkokari-gtyih Aug 19, 2026
5809b70
chore: Use single quotes instead of double quotes
kakkokari-gtyih Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/ipaddr.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export function isValidCIDR(addr: string): boolean;
export function parse(addr: string): IPv4 | IPv6;
export function parseCIDR(mask: string): [IPv4 | IPv6, number];
export function process(addr: string): IPv4 | IPv6;
export function subnetMatch(addr: IPv4 | IPv6, rangeList: RangeList<IPv4 | IPv6>, defaultName?: string): string;
export function subnetMatch<L extends RangeList<IPv4 | IPv6>, D extends string = 'unicast'>(addr: IPv4 | IPv6, rangeList: L, defaultName?: D): keyof L | D;

export class IPv4 extends IP {
static broadcastAddressFromCIDR(addr: string): IPv4;
Expand All @@ -39,7 +39,7 @@ export class IPv4 extends IP {
kind(): 'ipv4';
match(what: IPv4 | IPv6 | [IPv4 | IPv6, number], bits?: number): boolean;
range(): IPv4Range;
subnetMatch(rangeList: RangeList<IPv4>, defaultName?: string): string;
subnetMatch<L extends RangeList<IPv4>, D extends string = 'unicast'>(rangeList: L, defaultName?: D): keyof L | D;
toIPv4MappedAddress(): IPv6;
}

Expand All @@ -60,7 +60,7 @@ export class IPv6 extends IP {
kind(): 'ipv6';
match(what: IPv4 | IPv6 | [IPv4 | IPv6, number], bits?: number): boolean;
range(): IPv6Range;
subnetMatch(rangeList: RangeList<IPv6>, defaultName?: string): string;
subnetMatch<L extends RangeList<IPv6>, D extends string = 'unicast'>(rangeList: L, defaultName?: D): keyof L | D;
toIPv4Address(): IPv4;
toRFC5952String(): string;
}