CIDR parsing fails to apply mask. #144

Activity

1. kennethtran93 commented on Aug 1, 2020

   

   kennethtran93

   on Aug 1, 2020

   Last edited by kennethtran93

   Contributor

   More actions

   This is because it parses the IP and CIDR separately. CIDR is used for checking through another function.

   The octets stored is the one used from parsing the IP address irregardless of the existence of CIDR, thus toString will only return the parsed IP address, and if CIDR was given, then appends it afterwards.

   You'll need to use the match function to test for CIDR (which only exists when using the parse function, not parseCIDR.

   so

   ipaddr.IPv4.parse('8.3.4.8').match(ipaddr.IPv4.parseCIDR('8.3.4.0/24'))

   or

   ipaddr.IPv4.parse('8.3.4.8').match(ipaddr.parse('8.3.4.0'), 24)

   or

   ipaddr.IPv4.parse('8.3.4.0').match(ipaddr.parse('8.3.4.8'), 24)

   or

   const test = ipaddr.IPv4.parseCIDR('8.3.4.8/24');
   ipaddr.IPv4.parse('8.3.4.0').match(test[0], test[1]);

   The parser doesn't know about any CIDR notations. It is only passed in the IP address string (without CIDR) for parsing. This is the same if you use parseCIDR, as it send everything before the slash to the parser for IP Address.