chore: Sync main with dev - #22
Merged
Merged
Conversation
Invited users can now accept or decline a workspace invitation through the API, completing the invitation lifecycle that previously supported only creating and cancelling invites. The invite and join moments now emit events, so a host application can react to them, for example to deliver the invitation email.
Member, owner, and admin lists came back empty for any app that uses its own Workspace subclass: the lookups compared against the base package class while the stored role assignments reference the configured model. They now resolve against the actual model, so members appear as expected.
Reconcile the diverged branches: bring dev's outstanding change (the workspace-subclass member-lookup fix) onto main and align the version and changelog to 1.1.1. Resolves the only conflicts, which were the version and changelog entries.
Code Review SummaryThis PR updates the 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| RoleAssignment::create([ | ||
| 'assignable_type' => User::class, | ||
| 'assignable_id' => $user->id, | ||
| 'role_id' => Role::where('slug', 'owner')->first()->id, |
There was a problem hiding this comment.
Relying on first() without checking for null can lead to errors if the database state is unexpected. While likely seeded in tests, using firstOrFail() or a explicit check is safer.
Suggested change
| 'role_id' => Role::where('slug', 'owner')->first()->id, | |
| 'role_id' => Role::where('slug', 'owner')->firstOrFail()->id, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.