-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Honour a workspace subclass when listing members #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,50 @@ | ||||||
| <?php | ||||||
|
|
||||||
| namespace Tests\Feature; | ||||||
|
|
||||||
| use Illuminate\Support\Facades\Hash; | ||||||
| use PHPUnit\Framework\Attributes\Test; | ||||||
| use Tests\TestCase; | ||||||
| use Whilesmart\Roles\Models\Role; | ||||||
| use Whilesmart\Roles\Models\RoleAssignment; | ||||||
| use Whilesmart\Workspaces\Models\Workspace; | ||||||
| use Workbench\App\Models\User; | ||||||
|
|
||||||
| class SubWorkspace extends Workspace | ||||||
| { | ||||||
| protected $table = 'workspaces'; | ||||||
| } | ||||||
|
|
||||||
| class SubclassedWorkspaceTest extends TestCase | ||||||
| { | ||||||
| #[Test] | ||||||
| public function members_resolve_when_the_workspace_model_is_subclassed(): void | ||||||
| { | ||||||
| config(['workspaces.workspace_model' => SubWorkspace::class]); | ||||||
|
|
||||||
| $user = User::create([ | ||||||
| 'name' => 'Sub Owner', | ||||||
| 'email' => 'sub-'.uniqid().'@example.com', | ||||||
| 'password' => Hash::make('password'), | ||||||
| ]); | ||||||
|
|
||||||
| $workspace = SubWorkspace::create([ | ||||||
| 'name' => 'Sub Workspace', | ||||||
| 'type' => 'team', | ||||||
| 'owner_type' => User::class, | ||||||
| 'owner_id' => $user->id, | ||||||
| ]); | ||||||
|
|
||||||
| RoleAssignment::create([ | ||||||
| 'assignable_type' => User::class, | ||||||
| 'assignable_id' => $user->id, | ||||||
| 'role_id' => Role::where('slug', 'owner')->first()->id, | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hardcoding the role slug as 'owner' might be fragile if the system relies on specific slugs like 'workspace-owner' (as seen in the model methods). Consider using the slug that matches the logic being tested.
Suggested change
|
||||||
| 'context_type' => SubWorkspace::class, | ||||||
| 'context_id' => $workspace->id, | ||||||
| ]); | ||||||
|
|
||||||
| // Before the fix this returned 0, because the lookup filtered on the | ||||||
| // base Workspace class while the assignment stores the subclass. | ||||||
| $this->assertCount(1, $workspace->members()->get()); | ||||||
| } | ||||||
| } | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
static::classinstead ofself::classenables Late Static Binding. This ensures that if a developer extends theWorkspacemodel, the query will correctly filter by the child class name stored in the database.