Conversation
Invited users can now accept or decline a workspace invitation through the API, completing the invitation lifecycle that previously supported only creating and cancelling invites. The invite and join moments now emit events, so a host application can react to them, for example to deliver the invitation email.
Code Review SummaryThis PR updates the workspace management package to version 1.1.0. It introduces essential features for handling workspace invitations (accept/decline) and implements an event-driven system to allow host applications to respond to membership changes. 🚀 Key Improvements
💡 Minor Suggestions
|
| return response()->json(['error' => 'Unauthorized'], 401); | ||
| } | ||
|
|
||
| $invitation = WorkspaceInvitation::where('token', $token)->firstOrFail(); |
There was a problem hiding this comment.
Using firstOrFail() with a non-ID lookup in an API context is generally fine, but consider whether you want to expose a 404 for an invalid token or a more specific 422 if the token simply doesn't exist. For tokens, 404 is appropriate, but ensure you have a custom exception handler if you want to return a JSON error message instead of the default HTML 404 page.
Suggested change
| $invitation = WorkspaceInvitation::where('token', $token)->firstOrFail(); | |
| $invitation = WorkspaceInvitation::where('token', $token)->first(); | |
| if (! $invitation) { | |
| return response()->json(['error' => 'Invalid or expired invitation token'], 404); | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1.1.0] - 2026-06-13
Added
MemberInvitedandMemberJoinedevents are now dispatched (on invite and on accept), letting host apps react -- for example to send an invitation email