Open
Conversation
…edefined dropdown list with fixed values). In the Log Page, increasing the weight with the quick add and remove buttons now use the minimum weight plate available.
rolandgeider
reviewed
Mar 5, 2026
Comment on lines
+64
to
+68
| // Calculate weightRounding as 2 times the smallest available plate weight | ||
| final plateProvider = ref.read(plateCalculatorProvider.notifier); | ||
| final selectedPlates = plateProvider.state.selectedPlates; | ||
| final minPlate = selectedPlates.isNotEmpty ? selectedPlates.reduce((a, b) => a < b ? a : b) : 1.25; | ||
| final calculatedWeightRounding = 2 * minPlate; |
Member
There was a problem hiding this comment.
we could just move all this to within the plate provider and just expose a minWeightRounding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR also includes a lot of automatic quick fixes proposed by VSCode when first opening the project. Looks mostly like lint stuff. You can probably discard the commit "automatic fixes" and only keep the other commit if you wish.
Related Issue(s)
Please check that the PR fulfills these requirements