Open
Conversation
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
- Add `Aaguid.extract` to parse AAGUID from attestation objects - Add `Aaguid.lookup` to resolve authenticator metadata (name, icons) from the passkey-authenticator-aaguids registry - Include `aaguid` in `Registration.verify` response (optional — `undefined` when not decodable) - Update Hono example to display authenticator name & icon via AAGUID lookup
e653670 to
f5215db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aaguid.extractto parse AAGUID from attestation objectsAaguid.lookupto resolve authenticator metadata (name, icons) from the passkey-authenticator-aaguids registryaaguidinRegistration.verifyresponse (optional —undefinedwhen not decodable)Logic:
webauthxalways extracts the rawaaguidsynchronously duringRegistration.verify(...), andAaguid.lookup({ id, remoteList?, fetchFn?, cache? })optionally resolves friendly metadata by fetching a remote registry. The lookup usesremoteListif provided, otherwise defaults to the GitHubcombined_aaguid.jsonURL, usesfetchFnif provided orglobalThis.fetchotherwise, normalizesAAGUIDkeys to lowercase plus upstream snake_case/camelCase icon fields, and caches the fetched registry in a module-level in-memoryMapkeyed by URL so later lookups reuse the same cached result or in-flight promise; cache: false bypasses that, and failed fetches are evicted so retries can succeed.Aaguid.lookup:Aaguid.extract: