feat: add stripe connect settlement options#473
Merged
Conversation
commit: |
logananderson-stripe
approved these changes
May 21, 2026
logananderson-stripe
left a comment
logananderson-stripe
left a comment
There was a problem hiding this comment.
Looks great! Left a couple of comments but nothing blocking
| > & { decimals: number } | ||
|
|
||
| type ConnectSettlement = { | ||
| /** Connected account used as the Stripe account context for the request. */ |
There was a problem hiding this comment.
Would it be possible to add the stripe docs link here?
| return { | ||
| applicationFeeAmount: 12, | ||
| onBehalfOf: 'acct_merchant', | ||
| stripeAccount: 'acct_platform', |
There was a problem hiding this comment.
nit: stripeAccount is normally the connected account not the platform
| return settlement | ||
| } | ||
|
|
||
| function validateAccountId(value: string | undefined, name: string) { |
There was a problem hiding this comment.
Its awesome to have these basic validations but I am assuming we return an error if the payment intent fails to create? For example, if the platform doesn't have access to the merchant or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added server-side Stripe Connect settlement options for Stripe charge PaymentIntent creation.