Skip to content

fix(cli): fail fast on hanging keychain commands#272

Merged
brendanjryan merged 3 commits intomainfrom
brendanryan/fail-fast-keychain-commands
Mar 31, 2026
Merged

fix(cli): fail fast on hanging keychain commands#272
brendanjryan merged 3 commits intomainfrom
brendanryan/fail-fast-keychain-commands

Conversation

@brendanjryan
Copy link
Copy Markdown
Collaborator

@brendanjryan brendanjryan commented Mar 31, 2026

Context

Attempt to address hanging tests on prs / main

Summary

  • add bounded timeouts for CLI keychain subprocesses
  • kill hanging Linux secret-tool store calls instead of waiting forever
  • harden runtime test server teardown so HTTP helpers aggressively close sockets and avoid lingering keep-alive state
  • make the keychain timeout configurable with MPPX_KEYCHAIN_COMMAND_TIMEOUT_MS

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

Open in StackBlitz

npm i https://pkg.pr.new/mppx@272

commit: 9b67c04

@brendanjryan brendanjryan merged commit 54d6279 into main Mar 31, 2026
7 checks passed
@brendanjryan brendanjryan deleted the brendanryan/fail-fast-keychain-commands branch March 31, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant