Repository navigation
B88: media moments - #68
Merged
Merged
Conversation
⌘⇧K marks the start of a moment, then the end, saves it and pauses; with a loop set, one press saves the loop. ⌘⇧J saves the last 30 seconds. A moment is a card next to its page's card with its times and the captions shown during it. On the card: change the times, Play (opens the page at the start and loops the range) and Ask for ID (a question the moment raises). Trail files, Replay, the timeline and search past trails know moments. Also updates the B62 row: Mac signing is done; the passkey entitlement waits on Apple. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011V7Bv7WZ9Q92MZoNWYwevQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B88. Media moments: save a section of a video or audio page, with its captions, as a card.
The keys (your choice: both ways)
The moment card (your choice: a card next to the page)
41:12–42:30, Enter.Elsewhere
### [Title](page) · moment 41:12–42:30with the captions as a quoted line (doc 26). Stillnode-trail: 2.Also in this PR: the B62 row now says Mac signing is done and the passkey entitlement is waiting on Apple (docs only).
Code
core/page-scripts.js:momentScript;loopScriptoprange(video or audio).core/trail.js:momentCard,momentTimes(eventedited), card kindmoment.core/trail-file.js,core/replay.js,core/recall.js: the file format, the caption, search.main.js:saveMoment, menu items,tab:moment,trail:moment-play,trail:moment-times,trail:moment-id.renderer/canvas.js,app.js,styles.css: the card, the timeline label. Tokens only.Not in this PR: the Chromium build.
Tests
test/moment-demo.js(npm run test:moment, intest:unit): 7 checks.test/e2e/52-media-moments.js(17 checks), in both CI e2e lists. Its test page loads the video into memory so it can seek, since the test server can't serve parts of a file.test:unit, and e2e 10, 25, 34, 42, 43, 44, 48 and 51 still pass.Generated by Claude Code