[Opus 4.6] Support IMAP accounts in delete-staged command#223
Open
DominicHolmes wants to merge 1 commit intowesm:mainfrom
Open
[Opus 4.6] Support IMAP accounts in delete-staged command#223DominicHolmes wants to merge 1 commit intowesm:mainfrom
DominicHolmes wants to merge 1 commit intowesm:mainfrom
Conversation
delete-staged previously hardcoded Gmail OAuth client creation, causing it to fail for IMAP accounts with "OAuth client secrets not configured". The IMAP client already implements the gmail.API deletion interface, so this wires up source-type detection and reuses buildAPIClient to route IMAP accounts through the IMAP client path. Closes wesm#221 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human note: this fixed my use case (processing a ton of iCloud-hosted emails). Code looks reasonable to me, but I don't know golang. iCloud (IMAP) path is tested, Gmail path is untested (I don't have a gmail).
===========
Summary
delete-stagednow detects account type and routes IMAP accounts through the IMAP client path instead of always assuming Gmail OAuthbuildAPIClientfactory (same one used by sync) to avoid duplicating IMAP client constructionCloses #221
Testing
Tested end-to-end on a real iCloud IMAP account:
UID STORE \Deleted+UID EXPUNGE.--dry-runworks correctly for IMAP accountsmake test)go fmtandgo vetclean🤖 Generated with Claude Code