Disallow arrays in orderBy of SomeQuery#68
Closed
SH-Exact wants to merge 2 commits into
Closed
Conversation
Sharpen NonArrayProps type
|
|
||
| export type SomeQuery<E, F, I, P> = SomeQueryBase<E, F, I, P> & | ||
| ({ sort?: Sort<E>[]; orderBy?: never } | { sort?: never; orderBy?: OrderBy<F>[] }); | ||
| ({ sort?: Sort<E>[]; orderBy?: never } | { sort?: never; orderBy?: OrderBy<NonArrayProps<F>>[] }); |
Contributor
There was a problem hiding this comment.
It is still possible to use array properties in the orderBy query. In the following example the topics prop of opportunity entity is available.
Contributor
Author
|
Won't be done for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
NonArrayPropstype which strips away array properties of a type to be able to useorderByin aSomeQuerywith proper types. The types which can be used fororderByin aSomeQueryare basically the*_Filter_Propstypes without arrays.