fix: use doc-kit's island theme toggle - #241
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⚡ Lighthouse reportAudited the Vercel preview deployment: https://webpack-doc-m9y1z4ad2-openjs.vercel.app
|
Walkthrough
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
components/NavBar.jsx (1)
12-12: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy liftUse a stable
@doc-kit/generator-reactimport surface in both navigation components.Both imports reach into
node_modules/.../src/...instead of using a supported package entry point. Verify that@doc-kit/generator-react@0.1.0intentionally exposes these files in every supported install. Prefer a public export or stable subpath.
components/NavBar.jsx#L12-L12: importThemeTogglethrough the supported generator-package entry point.components/SideBar.jsx#L8-L8: importwithIslandthrough the supported generator-package entry point.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 80f48319-dfc8-4aa7-b1f1-4c41fda7297d
📒 Files selected for processing (2)
components/NavBar.jsxcomponents/SideBar.jsx
1fa1127 to
9349622
Compare
Summary
Fixes the theme toggle and sidebar wrapped withIsland
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
No
Does this PR introduce a breaking change?
no
If relevant, what needs to be documented once your changes are merged or what have you already documented?
no
Use of AI
no
Summary by CodeRabbit