Skip to content

fix: use doc-kit's island theme toggle - #241

Merged
moshams272 merged 1 commit into
mainfrom
fix/island-hydration
Aug 14, 2026
Merged

fix: use doc-kit's island theme toggle#241
moshams272 merged 1 commit into
mainfrom
fix/island-hydration

Conversation

@ryzrr

@ryzrr ryzrr commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary
Fixes the theme toggle and sidebar wrapped withIsland

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
No

Does this PR introduce a breaking change?
no

If relevant, what needs to be documented once your changes are merged or what have you already documented?
no

Use of AI
no

Summary by CodeRabbit

  • New Features
    • Added a theme toggle to the navigation bar for easier appearance switching.
    • Improved sidebar loading behavior so it initializes during browser idle time, helping the page load more efficiently.

@vercel

vercel Bot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview Aug 13, 2026 10:40am

Request Review

@github-actions github-actions Bot added the theme label Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

⚡ Lighthouse report

Audited the Vercel preview deployment: https://webpack-doc-m9y1z4ad2-openjs.vercel.app

URL Performance Accessibility Best Practices SEO Report
/ 🟢 99 🟢 96 🟢 100 🟢 100 🔗
/about 🟢 100 🟢 97 🟢 100 🟢 100 🔗
/about/sponsors 🟠 85 🟢 95 🟢 100 🟢 100 🔗
/blog 🟢 100 🟢 96 🟢 100 🟢 100 🔗
/blog/posts/2026-02-04-roadmap-2026 🟢 100 🟢 93 🟢 100 🟢 100 🔗
/guides/getting-started 🟢 95 🟢 93 🟢 100 🟢 100 🔗
/docs/api/options 🔴 69 🟢 96 🟢 100 🟢 100 n/a
/docs/loaders/css-loader 🟢 100 🟢 97 🟢 100 🟠 83 🔗

Scores are advisory (warn at 90); they do not fail the build. See .lighthouserc.json.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

NavBar now imports ThemeToggle from the local generator package and removes local theme state management. It renders ThemeToggle without theme-related props. SideBar is now a named Sidebar component. Its default export uses withIsland with browser idle initialization enabled.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: using doc-kit’s island theme toggle to fix theme behavior.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/island-hydration

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
components/NavBar.jsx (1)

12-12: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy lift

Use a stable @doc-kit/generator-react import surface in both navigation components.

Both imports reach into node_modules/.../src/... instead of using a supported package entry point. Verify that @doc-kit/generator-react@0.1.0 intentionally exposes these files in every supported install. Prefer a public export or stable subpath.

  • components/NavBar.jsx#L12-L12: import ThemeToggle through the supported generator-package entry point.
  • components/SideBar.jsx#L8-L8: import withIsland through the supported generator-package entry point.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 80f48319-dfc8-4aa7-b1f1-4c41fda7297d

📥 Commits

Reviewing files that changed from the base of the PR and between f02a9a0 and 1fa1127.

📒 Files selected for processing (2)
  • components/NavBar.jsx
  • components/SideBar.jsx

@moshams272
moshams272 merged commit c252791 into main Aug 14, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants