Skip to content

feat: add kotlin views for tree#896

Open
cliebhardt wants to merge 3 commits into
kotlin/integrationfrom
kotlin/tree
Open

feat: add kotlin views for tree#896
cliebhardt wants to merge 3 commits into
kotlin/integrationfrom
kotlin/tree

Conversation

@cliebhardt

@cliebhardt cliebhardt commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cliebhardt cliebhardt added the status: waiting-for-review The PR is ready. Waiting for team members to review. label Mar 29, 2026
EHandtkeBasis
EHandtkeBasis requested changes Mar 30, 2026
View reviewed changes
Comment thread src/main/kotlin/com/webforj/samples/views/tree/TreeKotlinView.kt Outdated
Comment thread src/main/kotlin/com/webforj/samples/views/tree/TreeIconsKotlinView.kt Outdated
Comment thread src/main/kotlin/com/webforj/samples/views/tree/TreeIconsKotlinView.kt Outdated
Comment thread src/main/kotlin/com/webforj/samples/views/tree/TreeIconsKotlinView.kt Outdated
Comment thread src/main/kotlin/com/webforj/samples/views/tree/TreeLazyLoadKotlinView.kt Outdated
Comment thread src/main/kotlin/com/webforj/samples/views/tree/TreeModifyKotlinView.kt
defaultValue = node.text
firstButtonText = "Modify"
secondButtonText = "Cancel"
setFirstButtonTheme(ButtonTheme.PRIMARY)

@EHandtkeBasis EHandtkeBasis Mar 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setFirstButtonTheme(ButtonTheme.PRIMARY) — use property syntax if InputDialog exposes a getter:

firstButtonTheme = ButtonTheme.PRIMARY

@cliebhardt cliebhardt Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property is not available for set*ButtonTheme of OptionDialogs.

Comment thread src/main/kotlin/com/webforj/samples/views/tree/TreeSelectionKotlinView.kt Outdated
@EHandtkeBasis EHandtkeBasis added status: waiting-for-author Review is done. Waiting for the PR author to apply changes or respond. and removed status: waiting-for-review The PR is ready. Waiting for team members to review. labels Mar 30, 2026
@cliebhardt cliebhardt added Kotlin status: needs-snapshot Update to the latest snapshot before this PR can be merged. status: blocked Waiting on external dependency or details labels Apr 1, 2026
@cliebhardt
cliebhardt force-pushed the kotlin/integration branch from f6aea25 to 6b078c0 Compare May 29, 2026 10:12
@cliebhardt cliebhardt added status: waiting-for-review The PR is ready. Waiting for team members to review. and removed status: needs-snapshot Update to the latest snapshot before this PR can be merged. status: waiting-for-author Review is done. Waiting for the PR author to apply changes or respond. status: blocked Waiting on external dependency or details labels Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EHandtkeBasis EHandtkeBasis EHandtkeBasis requested changes
@hyyan hyyan Awaiting requested review from hyyan hyyan is a code owner
@MatthewHawkins MatthewHawkins Awaiting requested review from MatthewHawkins MatthewHawkins is a code owner
@bbrennanbasis bbrennanbasis Awaiting requested review from bbrennanbasis bbrennanbasis is a code owner
@gosteenBASIS gosteenBASIS Awaiting requested review from gosteenBASIS gosteenBASIS is a code owner
@laurenic0l laurenic0l Awaiting requested review from laurenic0l laurenic0l is a code owner

Assignees

@EHandtkeBasis EHandtkeBasis

Labels

Kotlin status: waiting-for-review The PR is ready. Waiting for team members to review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cliebhardt @EHandtkeBasis