Skip to content

Improve support for PHPUnit 10, dropping older #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MalteWunsch merged 3 commits into from
Sep 5, 2025
Merged

Improve support for PHPUnit 10, dropping older #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
804e6c1
Drop support for phpunit/phpunit 8 and 9
MalteWunsch Sep 5, 2025
f0bc13b
Update deprecated PHPUnit configuration schema
MalteWunsch Sep 5, 2025
d706c42
Declare data provider methods static
MalteWunsch Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
vendor/
tools/
slimdump.phar
.phpunit.cache
phpunit.xml
.php-cs-fixer.cache
.phpunit.result.cache
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"symfony/service-contracts": "^2.1.2|^3.0"
},
"require-dev": {
"phpunit/phpunit": "^8.5|^9.5|^10.0"
"phpunit/phpunit": "^10.0"
},
"autoload": {
"psr-4": {
Expand Down
27 changes: 11 additions & 16 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
<?xml version="1.0" encoding="UTF-8"?>

<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/8.5/phpunit.xsd"
bootstrap="vendor/autoload.php"
>
<testsuites>
<testsuite name="Slimdump Test Suite">
<directory>test</directory>
</testsuite>
</testsuites>

<filter>
<whitelist>
<directory>src</directory>
</whitelist>
</filter>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="vendor/autoload.php" cacheDirectory=".phpunit.cache">
<testsuites>
<testsuite name="Slimdump Test Suite">
<directory>test</directory>
</testsuite>
</testsuites>
<source>
<include>
<directory>src</directory>
</include>
</source>
</phpunit>
2 changes: 1 addition & 1 deletion test/Webfactory/Slimdump/Config/FakerReplacerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public function testValidateReplacementConfiguredNotExisting()
*
* @return array
*/
public function provideValidReplacementIds()
public static function provideValidReplacementIds()
{
return [
[FakerReplacer::PREFIX.'firstname'], // original faker property
Expand Down
2 changes: 1 addition & 1 deletion test/Webfactory/Slimdump/Config/TableTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public function testDumpTriggerAttribute($value, $expected)
$this->assertEquals($table->isTriggerDumpRequired(), Table::TRIGGER_SKIP !== $expected);
}

public function dumpTriggerAttributeValues()
public static function dumpTriggerAttributeValues()
{
return [
['true', Table::DEFINER_NO_DEFINER],
Expand Down