fix(meetings): validate reaction relay route binding#4970
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d04eb826e1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const isPracticeSession = llm.isConnected(LLM_PRACTICE_SESSION); | ||
| const expectedBinding = isPracticeSession | ||
| ? llm.getBinding(LLM_PRACTICE_SESSION) | ||
| : llm.getBinding(); |
There was a problem hiding this comment.
Validate against the event's session binding
When the practice-session socket is connected, this always compares every relay event to the practice binding, even events delivered on the default LLM channel. Mercury tags each incoming envelope with its sessionId and emits default events on event:relay.event while practice events use event:relay.event:llm-practice-session; because both listeners remain registered, a default-session reaction with headers.route === llm.getBinding() will now be skipped whenever the practice channel is also connected. Use the event/session that delivered the relay event to choose the binding instead of global practice connectivity.
Useful? React with 👍 / 👎.
Description
event.headers.route.Testing
Focused
#processRelayEventblock passed: 7 passing.