fix(plugin-meetings): reset stale share state during whiteboard handoff#4961
Open
mickelr wants to merge 16 commits into
Open
fix(plugin-meetings): reset stale share state during whiteboard handoff#4961mickelr wants to merge 16 commits into
mickelr wants to merge 16 commits into
Conversation
marcin-bazyl
reviewed
May 8, 2026
| } | ||
| } | ||
|
|
||
| if (isAccepting) { |
Collaborator
There was a problem hiding this comment.
the fix seems OK, but I don't think it will fix the actual issue with sharing. The issue it's fixing is just an unnecessary notification about whiteboard started when it's already started, so it won't change anything in the app state. It will stop SDK from sending an incorrect CA event about whiteboard, but I don't think that will have any effect on CA either.
However, any fixes in this area are high risk as they will affect whiteboards and screen sharing for all meetings and I don't understand the changes in the unit tests - the existing code in these unit tests seem overly complicated and these changes are hard to read. Are you able to explain all these changes in the tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a webinar share-render failure during a whiteboard -> file/content share handoff.
When Locus reports
whiteboard.disposition = RELEASEDandcontent.disposition = ACCEPTED,Meeting.setUpLocusMediaSharesListener()used to keep the previouswhiteboard_share_activestate. That caused the SDK to re-emit whiteboard-start behavior for an already released whiteboard before the real content share was granted.This PR defaults the computed share status to
NO_SHARE, allowing onlyGRANTEDcontent/whiteboard states to override it. Intermediate/non-active floor states such asACCEPTEDno longer carry stale share state forward.Root cause
Before this change:
If content was
ACCEPTEDand whiteboard wasRELEASED, none of the existingGRANTED/RELEASED/nullbranches matched, sonewShareStatusremained stale aswhiteboard_share_active.Expected behavior after fix
For the failing sequence:
This avoids the spurious
MEETING_STARTED_SHARING_WHITEBOARDevent and gives consumers a clean whiteboard-stop then remote-share-start handoff.Tests
Temporarily focused the relevant
setUpLocusMediaSharesListenerblock per plugin-meetings guidance, ran the targeted meeting test file, and removed.onlyafterward.Result:
Also ran:
Result: no whitespace/diff-check errors.