test(calling): add transfer consult flows by eigengravy · Pull Request #4939 · webex/webex-js-sdk

eigengravy · 2026-04-30T06:23:08Z

COMPLETES https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7882

This pull request addresses

Follow-up to #4879 — adds 3-user transfer & consult call-flow Playwright E2E
coverage for the Calling SDK on top of the existing 2-user suite, and hardens
call cleanup / selectors that surfaced while iterating on the new flows.

by making the following changes

Enables the SET_3USER - PROD and SET_3USER - INT Playwright projects (depend on SET_2USER)
Adds suites/set-3user.spec.ts as the 3-user suite entry point
Adds test-groups/transfer-tests.ts with blind transfer and consult transfer flows

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

Automated: new 3-user transfer suite (blind + consult transfer) run locally against the Calling SDK samples page via SET_3USER - PROD / SET_3USER - INT
Automated: existing 2-user call flows, SDK init, and device registration suites re-run to confirm no regressions

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly

- Target visible incoming #answer via #incomingsection scope to avoid the hidden duplicate in the sample app - Make cleanupActiveCalls retry-capable with a direct call.end() fallback, and invoke it before context teardown - Fix withTimeout to clear its timer on settle so promises do not leak handles - Tolerate resumeCall being entered from either Hold or Resume state - Guard unregisterLine against closed pages / already-unregistered state, and wait for "Unregistered" rather than "Un registering"

aws-amplify-us-east-2 · 2026-04-30T06:32:57Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4939.d3m3l2kee0btzx.amplifyapp.com

Enable the SET_3USER Playwright projects (PROD + INT) and add the transfer/consult test group that runs against them. Picks up the checkpoint that was lost during an earlier reset + rebase. - packages/calling/playwright.config.ts: enable SET_3USER projects - packages/calling/playwright/suites/set-3user.spec.ts: suite entry - packages/calling/playwright/test-groups/transfer-tests.ts: blind and consult transfer flows

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c019e875a1

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-06T03:31:38Z

+        // Page may have closed during teardown
+      }
+    });
+    test.afterAll(() => group.teardown());


Use a defined cleanup method in afterAll

setupThreeUserGroup() returns setup, cleanupAfterEach, and getters, but no teardown method, so test.afterAll(() => group.teardown()) throws TypeError: group.teardown is not a function when this describe finishes. That causes this suite to fail during teardown and skips the intended final cleanup path for the shared 3-user contexts.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea0d907a9d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-10T13:23:38Z

+      name: 'SET_3USER - PROD',
+      dependencies: ['SET_2USER - PROD'],
+      testDir: './playwright/suites',
+      testMatch: USER_SETS.SET_3USER.testSuite,


Gate SET_3USER projects behind USER_6 OAuth prerequisites

Enabling SET_3USER here makes USER_6 mandatory for every default Playwright run, but OAuth setup still treats USER_6 as optional (REQUIRED_OAUTH_ROLES excludes it), so environments without USER_6_* credentials/token will pass OAuth setup and then fail later when TestManager requests getToken('USER_6') for the third context. This turns the new projects into a deterministic runtime failure in CI/local setups that only provision USER_1..USER_5.

Useful? React with 👍 / 👎.

riteshfyi · 2026-05-13T06:54:50Z

+        await settleUi(callerPage);
+        await callerPage.locator(CALLING_SELECTORS.TRANSFER_BTN).click({timeout: AWAIT_TIMEOUT});
+        await callerPage.waitForTimeout(POST_ACTION_SETTLE_MS);
+      } finally {


Maybe Add a Catch here, in case something actually fails.
Rest Looks Good.

Kesari3008 · 2026-05-13T09:18:37Z

+} from '../utils/call';
+import {CALLING_SELECTORS, AWAIT_TIMEOUT} from '../constants';
+
+const UI_SETTLE_MS = 3000;


We have timeouts.ts file right where we defined timeout related constants , move these there

Kesari3008 · 2026-05-13T09:34:39Z

+
+export function transferTests() {
+  test.describe('Transfer - Blind', () => {
+    test.describe.configure({mode: 'serial', timeout: 240000});


We can constant added for this timeout that we are using in describe blocks and mode as well

Kesari3008 · 2026-05-13T09:36:01Z

+      await group.teardown();
+    });
+
+    test('CALL-024: Consult transfer - caller consults then commits transfer to third party', async () => {


Add scenarios where user on hold drops the call before consult transfer completes and scenarios where transferror puts the consulted user on hold and resumes the initial user.

Kesari3008 · 2026-05-13T09:37:26Z

+  );
+};
+
+const setupThreeUserGroup = () => {


These methods can be present in util file right. If we have separate folder created to keep utility methods, then these may also qualify to be moved there

Kesari3008 · 2026-05-13T09:38:30Z

+      await group.teardown();
+    });
+
+    test('CALL-009: Blind transfer completion - caller transfers call to third party', async () => {


How are we coming up with these indexes: CALL-009 and then CALL-026 even though both are for blind transfer.

Kesari3008 · 2026-05-13T09:41:33Z

+      await callerPage.locator(CALLING_SELECTORS.TRANSFER_BTN).click({timeout: AWAIT_TIMEOUT});
+      await callerPage.waitForTimeout(POST_ACTION_SETTLE_MS);
+
+      await waitForCallDisconnect(callerPage, 30000);


Same comment here

Kesari3008 · 2026-05-13T09:59:53Z

+      await waitForCallDisconnect(calleePage);
+    });
+
+    test('CALL-027: Blind transfer rejection - transfer target rejects, original call remains', async () => {


In case of blind transfer, transferror would be disconnected from the call irrespective if the transfer is accepted or not I believe

Kesari3008 · 2026-05-13T10:00:13Z

+      await Promise.all([waitForCallDisconnect(callerPage), waitForCallDisconnect(calleePage)]);
+    });
+
+    test('CALL-017: ALL_CALLS_CLEARED - fires after last call ends (consult transfer)', async () => {


What is the significance of this test ?

Kesari3008 · 2026-05-13T10:02:24Z

+      await Promise.all([waitForCallDisconnect(callerPage), waitForCallDisconnect(calleePage)]);
+    });
+
+    test('CALL-004: Remote busy handling - caller dials callee already on a call', async () => {


Please elaborate this test, I don't fully understand. We establish call with transferpage and calleePage and then caller Page is busy.

Kesari3008 · 2026-05-13T10:02:58Z

-    //   use: {...browserOptions[PW_BROWSER], testEnv: 'int'} as any,
-    // },
+    {
+      name: 'SET_3USER - PROD',


As discussed, please come with a naming convention followed across all client modules

eigengravy added 2 commits April 30, 2026 11:12

feat: 2 user call flows

724c941

eigengravy marked this pull request as ready for review May 5, 2026 04:55

eigengravy requested a review from a team as a code owner May 5, 2026 04:55

eigengravy changed the title ~~test(calling): add transfer consult flows [WIP]~~ test(calling): add transfer consult flows May 5, 2026

eigengravy added the validated If the pull request is validated for automation. label May 5, 2026

chatgpt-codex-connector Bot reviewed May 6, 2026

View reviewed changes

test(calling): clean up transfer e2e flows

ea0d907

chatgpt-codex-connector Bot reviewed May 10, 2026

View reviewed changes

riteshfyi approved these changes May 13, 2026

View reviewed changes

Kesari3008 requested changes May 13, 2026

View reviewed changes

Conversation

eigengravy commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7882

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

I certified that

Uh oh!

aws-amplify-us-east-2 Bot commented Apr 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 6, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eigengravy commented Apr 30, 2026 •

edited

Loading