fix: handle unknown return type from getValue() in webdriverio 9.24.0#1435
Open
elaichenkov wants to merge 1 commit intomainfrom
Open
fix: handle unknown return type from getValue() in webdriverio 9.24.0#1435elaichenkov wants to merge 1 commit intomainfrom
elaichenkov wants to merge 1 commit intomainfrom
Conversation
getValue() now returns Promise<unknown> instead of Promise<string>. Use typeof guard instead of type assertion to safely handle non-string return values (e.g. null), returning false when value is not a string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dependabot PR #1431 (bumping
webdriveriofrom 9.23.2 to 9.24.0) fails to build with:In webdriverio 9.24.0,
element.getValue()return type changed fromPromise<string>toPromise<unknown>because it delegates togetElementProperty()(for W3C) which can return any JS type.Solution
Use a
typeofguard instead of a type assertion: