-
-
Notifications
You must be signed in to change notification settings - Fork 60
POC: Support multiremote take 2 #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
db529b3
927f1b7
f4b9de7
09ad6ea
57d310e
7ec8819
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,6 @@ | |
| "tsc:root-types": "node types-checks-filter-out-node_modules.js", | ||
| "test": "run-s test:*", | ||
| "test:tsc": "tsc --project tsconfig.json --noEmit --rootDir .", | ||
| "test:lint": "eslint .", | ||
| "test:unit": "vitest --run", | ||
| "test:types": "npm run ts && npm run tsc:root-types", | ||
| "ts": "run-s ts:* ts:*:*", | ||
|
|
@@ -78,6 +77,8 @@ | |
| }, | ||
| "dependencies": { | ||
| "@vitest/snapshot": "^4.1.10", | ||
| "@wdio/mocha-framework": "file:.yalc/@wdio/mocha-framework", | ||
| "@wdio/utils": "file:.yalc/@wdio/utils", | ||
|
Comment on lines
+80
to
+81
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "deep-eql": "^5.0.2", | ||
| "expect": "^30.4.1", | ||
| "jest-matcher-utils": "^30.4.1" | ||
|
|
@@ -92,7 +93,7 @@ | |
| "@vitest/coverage-v8": "^4.1.10", | ||
| "@vitest/eslint-plugin": "^1.6.26", | ||
| "@wdio/eslint": "^0.1.3", | ||
| "@wdio/types": "^9.30.1", | ||
| "@wdio/types": "file:.yalc/@wdio/types", | ||
| "eslint": "^9.39.5", | ||
| "husky": "^9.1.7", | ||
| "npm-run-all2": "^9.0.3", | ||
|
|
@@ -101,7 +102,7 @@ | |
| "strip-ansi": "^7.2.0", | ||
| "typescript": "^5.9.3", | ||
| "vitest": "^4.1.10", | ||
| "webdriverio": "^9.30.1" | ||
| "webdriverio": "file:.yalc/webdriverio" | ||
| }, | ||
| "peerDependencies": { | ||
| "@wdio/globals": "^9.0.0", | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,43 @@ | ||||||
| import { multiRemoteBrowser } from '@wdio/globals' | ||||||
|
|
||||||
| describe('WebdriverIO Custom Matchers', () => { | ||||||
| beforeEach(async () => { | ||||||
| await multiRemoteBrowser.url('https://webdriver.io') | ||||||
| }) | ||||||
|
|
||||||
| describe('Browser matchers', () => { | ||||||
| it('should verify browser title', async () => { | ||||||
| await expect(multiRemoteBrowser).toHaveTitle('WebdriverIO · Next-gen browser and mobile automation test framework for Node.js | WebdriverIO') | ||||||
| }) | ||||||
|
|
||||||
| it('should verify browser title contains text', async () => { | ||||||
| await expect(multiRemoteBrowser).toHaveTitle(expect.stringContaining('WebdriverIO')) | ||||||
| }) | ||||||
|
|
||||||
| it('should verify browser title contains text for each browser by array', async () => { | ||||||
| await expect(multiRemoteBrowser).toHaveTitle([expect.stringContaining('WebdriverIO'), expect.stringContaining('WebdriverIO')]) | ||||||
| }) | ||||||
|
|
||||||
| it('should verify browser title contains text for each browser by map', async () => { | ||||||
| await expect(multiRemoteBrowser).toHaveTitle({ | ||||||
| chrome: expect.stringContaining('WebdriverIO'), | ||||||
| firefox: expect.stringContaining('WebdriverIO') | ||||||
| }) | ||||||
| }) | ||||||
|
|
||||||
| it.only('should verify browser title contains text for one browser', async () => { | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The committed
Suggested change
|
||||||
| await expect(multiRemoteBrowser).toHaveTitle({ | ||||||
| firefox: expect.stringContaining('WebdriverIO') | ||||||
| }) | ||||||
| }) | ||||||
|
|
||||||
|
|
||||||
| // it('should verify browser URL', async () => { | ||||||
| // await expect(multiRemoteBrowser).toHaveUrl('https://webdriver.io/') | ||||||
| // }) | ||||||
|
|
||||||
| // it('should verify URL contains path', async () => { | ||||||
| // await expect(multiRemoteBrowser).toHaveUrl(expect.stringContaining('webdriver.io')) | ||||||
| // }) | ||||||
| }) | ||||||
| }) | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "version": "v1", | ||
| "packages": { | ||
| "@wdio/mocha-framework": { | ||
| "signature": "f5e7cba226f4b49b46c10b249e62cdce", | ||
| "file": true, | ||
| "replaced": "^9.30.1" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting
test:lintremoves ESLint from the wildcardnpm testpipeline used bychecks:all, allowing root validation to pass despite new lint violations.