Skip to content

fix: dashboard API calls use same-origin instead of hardcoded localhost ports #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
web3dev1337 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: dashboard API calls use same-origin instead of hardcoded localhost ports #1024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions client/dashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4534,9 +4534,9 @@ class Dashboard {
}

async installWindowsStartup() {
const serverUrl = window.location.port === '2080' ? 'http://localhost:3000' :
window.location.port === '2081' ? 'http://localhost:4000' :
window.location.origin;
// Same-origin: the client dev server proxies /api to the backend, which
// also works from remote browsers (a hardcoded localhost:PORT does not).
const serverUrl = window.location.origin;

// First check if we're on WSL
try {
Expand Down Expand Up @@ -4589,9 +4589,9 @@ class Dashboard {
}

async checkRecoveryState(workspaceId) {
const serverUrl = window.location.port === '2080' ? 'http://localhost:3000' :
window.location.port === '2081' ? 'http://localhost:4000' :
window.location.origin;
// Same-origin: the client dev server proxies /api to the backend, which
// also works from remote browsers (a hardcoded localhost:PORT does not).
const serverUrl = window.location.origin;

try {
const response = await fetch(`${serverUrl}/api/recovery/${encodeURIComponent(workspaceId)}`);
Expand Down Expand Up @@ -4687,9 +4687,9 @@ class Dashboard {

document.body.appendChild(modal);

const serverUrl = window.location.port === '2080' ? 'http://localhost:3000' :
window.location.port === '2081' ? 'http://localhost:4000' :
window.location.origin;
// Same-origin: the client dev server proxies /api to the backend, which
// also works from remote browsers (a hardcoded localhost:PORT does not).
const serverUrl = window.location.origin;

const setButtonsDisabled = (disabled) => {
modal.querySelectorAll('button').forEach((btn) => { btn.disabled = !!disabled; });
Expand Down
Loading