fix: adaptive terminal-grid scrolling based on usable row height - #1023
Open
web3dev1337 wants to merge 1 commit into
Open
fix: adaptive terminal-grid scrolling based on usable row height#1023web3dev1337 wants to merge 1 commit into
web3dev1337 wants to merge 1 commit into
Conversation
… pair count The grid used a hardcoded ">16 visible pairs" threshold: at 16 pairs on a short window every terminal was squeezed into an unreadable sliver, and at 17 it abruptly started scrolling regardless of how tall the monitor was. The toggle is now height-based — the grid scrolls exactly when sharing the viewport would push rows under a usable minimum (200px, matching the scrollable mode's existing row floor) — and is re-evaluated on window resize, so tall/portrait monitors fit more rows unscrolled and small windows stay readable. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateTerminalGridwith a height-based rule: the grid becomes scrollable exactly when squeezing all rows into the viewport would push a terminal-pair row below a usable minimum height (200px — same floor the scrollable mode'sgrid-auto-rows: minmax(200px, auto)already uses).Test plan
node --check client/app.jspasses.🤖 Generated with Claude Code