-
Notifications
You must be signed in to change notification settings - Fork 283
Add css gap decorations BCD keys #4046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
captainbrosset
wants to merge
4
commits into
main
Choose a base branch
from
gap-decorations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+330
−80
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a019d59
Add css gap decorations BCD keys
captainbrosset 1352c75
dist
captainbrosset a5abb2a
Merge branch 'main' of github.com:web-platform-dx/web-features into g…
captainbrosset 1c91c1b
Moved keys from multi-column to gap-decorations
captainbrosset File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems weird to me that properties that are over 10 years old are now under a headline status with no browser support at all. Can you elaborate on this?
(I'm wondering if there's some sort data issue here, like missing
flex_contextkeys, or else multiple features, something likegap-decoration-multicol,gap-decoration-flex, etc.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gap decorations started with the CSS multicol feature, a long time ago. At the time, it was only possible to decorate gaps in a multicol layout, and only vertical gaps (i.e. columns). At the time, also, gap decorations wasn't really considered as a separate feature, but instead was part of multicol.
Starting with Chrome/Edge 149, gap decorations is now its own, separate, feature. It now can be used both vertically and horizontally, and with grid, flex, and multicol.
Additionally, the feature now has a bunch of new properties to define exactly where the decorations start and end, how they cross, or where they appear at all.
My first idea was to only add the brand new BCD keys to gap-decorations.yml and leave other features untouched.
Then I thought it would make more sense to move the gap decorations-related keys that are in multi-column.yml to gap-decorations.yml.
This way, multi-column.yml is only about, well, multi-column (i.e. the column-width and column-count properties), and gap-decorations.yml contains the complete list of keys that make up the feature.
I did this mostly because multi-column.yml uses
compute_fromto pin its status to just one property.I can revert if the historical fact that column gap decorations for multicol only seems more important to preserve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess now that I've had more time to think on this, I think we do in fact have missing data.
If we merged this PR, then if I look up the compatibility information for this feature, it'll imply that I can set
column-ruleon a CSS grid container and get rules. But that's not true. It seems like something is missing from BCD, if that's the case (perhaps a key for<gap-rule-list>or agrid_contextkey). I think we need to file one or more bugs upstream, to decide how to represent that.But even if we had that stuff, gap decorations are conceptually different from multicol. Maybe there's a case to be made for a third reason to allow compat keys to be shared between two features (see https://github.com/web-platform-dx/web-features/pull/4034/changes#diff-1dd2fbbb7774410e5b66e9a554df689ef71981117b2c8fdd6570432cf0a13c59), when a key is an entry point into two or more features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
column-rulewould work on a CSS grid, only ifrow-ruleis also supported. The addition ofrow-rule(as well asrule, and a bunch of other long-hand properties) is sign that the "new" gap decorations are supported.Maybe the best thing to do here is to keep
column-rulewhere it was (in multicol) and only add the new BCD keys to the new feature.