Skip to content

feat(create-rspack): support rslint template mapping - #13882

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-create-rspack-rslint
Apr 30, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/feat-create-rspack-rslint

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Apr 30, 2026

Copy link
Copy Markdown
Member

Summary

This PR updates create-rspack to use create-rstack@2.1.1 so the generator can pass through the new Rslint template mapping support. It maps React templates to React-specific Rslint configs and all other framework templates to vanilla JS/TS configs.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings April 30, 2026 01:11
@github-actions github-actions Bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates create-rspack to use create-rstack@2.1.1 and wires in the new Rslint template mapping hook so generated projects select the appropriate Rslint config per template.

Changes:

  • Bump create-rstack from 2.0.1 to 2.1.1 (and update lockfile).
  • Add mapRslintTemplate to map React templates to React Rslint configs and others to vanilla JS/TS.
  • Pass the new mapRslintTemplate option into create().

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
pnpm-lock.yaml Updates the resolved create-rstack version/integrity to 2.1.1.
packages/create-rspack/src/index.ts Introduces and registers mapRslintTemplate for template→Rslint-config mapping.
packages/create-rspack/package.json Bumps create-rstack dependency to 2.1.1.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/create-rspack/package.json
@github-actions

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 8fad37d to feat(rslib): support emit isolated declarations (#13872) by Timeless0911

🙈 Size remains the same at 61.85MB

@github-actions

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 6 projects in monorepo, 6 projects with changes.

📊 Quick Summary
Project Total Size Change
popular-libs 1.7 MB -
react-10k 5.7 MB -
react-1k 826.1 KB -
react-5k 2.7 MB -
rome 1.6 MB -
ui-components 4.8 MB -
📋 Detailed Reports (Click to expand)

📁 popular-libs

Path: ../build-tools-performance/cases/popular-libs/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 1.7 MB - -
📄 JavaScript 1.7 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 826.1 KB - -
📄 JavaScript 826.1 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 1.6 MB - -
📄 JavaScript 1.6 MB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 4.8 MB - -
📄 JavaScript 4.7 MB - -
🎨 CSS 106.8 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@codspeed

codspeed Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 34 untouched benchmarks


Comparing chenjiahan/feat-create-rspack-rslint (8fad37d) with main (9f97557)

Open in CodSpeed

@chenjiahan
chenjiahan requested a review from fansenze April 30, 2026 01:44
@chenjiahan
chenjiahan enabled auto-merge (squash) April 30, 2026 01:44
@chenjiahan
chenjiahan merged commit 9d8c7cf into main Apr 30, 2026
43 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/feat-create-rspack-rslint branch April 30, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants