Skip to content

feat(community): add DeGiro Importer as verified community addon - #3

Open
shuisman wants to merge 2 commits into
wealthfolio:mainfrom
shuisman:add-degiro-importer
Open

feat(community): add DeGiro Importer as verified community addon#3
shuisman wants to merge 2 commits into
wealthfolio:mainfrom
shuisman:add-degiro-importer

Conversation

@shuisman

Copy link
Copy Markdown

Summary

  • Adds DeGiro Importer (degiro-importer) to the verified community tier
  • Imports buys, sells, dividends, deposits, withdrawals, fees, and taxes from DeGiro account statement CSVs
  • Handles Dutch-locale CSV quirks, partial-fill aggregation, and ISIN-to-ticker mapping via the configured market data provider
  • Source: https://github.com/shuisman/degiro-importer — pinned to v1.0.1 / b6fa986

Checklist

  • pnpm validate:addons passes (warnings only for missing screenshots — will add before merge if required)
  • pnpm generate run and community/README.md updated
  • Source repository is public with MIT license
  • Release tag v1.0.1 pinned with full commit SHA
  • Permissions declared with clear purposes in manifest.json
  • Support URL provided

Notes

Screenshots (cover-light.webp / cover-dark.webp) are not included in this initial PR. Happy to add them if required before merge.

🤖 Generated with Claude Code

shuisman and others added 2 commits June 20, 2026 14:07
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The Verified Community tier this PR targeted no longer exists. Moves the entry
under community/directory, drops the fields that only made sense when
Wealthfolio built and hosted the artifact, and adds the commercial model. Adds
the derived record read from the publisher's repository.

Validation fails until the addon is rebuilt: the manifest declares SDK 3.3.0,
which predates the sandbox, so nothing about where the addon sends data can be
established from it.
@afadil

afadil commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Thanks for this, and sorry it sat so long. I introduced the addon sandbox in 3.6 and reworked how community listings work before getting to the queue.

First the structural bit: I've dropped the Verified Community tier. Building, hosting and standing behind other people's code isn't something I can do properly on my own, and a "verified" badge that isn't a real code audit misleads people. So there are two channels now. Mine, in the app. Everyone else's, in a directory that links to your repo, where people download and install with "Install from File".

That's not a rejection of DeGiro Importer. I've pushed the conversion to your branch:

  • moved it to community/directory/degiro-importer/
  • removed verification, distribution, media, source and release, since Wealthfolio hosts nothing now (the sha256 in your PR was a zero placeholder anyway)
  • added "commercialModel": "free", tell me if that's wrong
  • dropped the community/README.md hunk, that file is generated now
  • added the derived record for your addon

You don't declare licence, compatibility or data handling any more. I read them from your repo.

One thing is blocking it, and CI is red because of it: your manifest declares SDK 3.3.0. The directory needs 3.6 or newer.

The reason isn't that old is bad. 3.6 added a sandbox, so an addon that doesn't ask for the network permission genuinely cannot reach the network. That lets the listing tell people "this addon keeps your data on your machine" and have it be true, because the runtime enforces it rather than the publisher promising it. Before 3.6 an addon could call out without declaring anything, so I can't say that about DeGiro Importer, and I'd rather publish nothing than publish a guess.

A rebuild against 3.7 fixes it and CI goes green. Your PR also declares minWealthfolioVersion: 3.3.0, so worth setting that to whatever you actually test against while you're in there.

Then post this as a comment and I'll merge:

I have read POLICIES.md and confirm:

- [ ] I am the publisher of this addon, or authorised to act for them.
- [ ] I have the rights to the name and description, and grant Wealthfolio permission to display them.
- [ ] The repository is public and has a licence file.
- [ ] What I declared is accurate, and my manifest declares every host the addon reaches.
- [ ] There is no hidden data collection or undisclosed remote code.
- [ ] I own support, updates, security fixes, privacy, licensing, and commercial terms.
- [ ] The name doesn't imply the addon is official or endorsed.
- [ ] A listing is a link only. Wealthfolio doesn't host, audit, endorse, or support it, and may remove it.

@blastik

blastik commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@shuisman i want to flag that i think before merging this addon has to be optimised a bit. i tried to use it and didnt work very well for me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants