Add WealthTax community directory addon - #2
Conversation
FIFO realized gains and open positions tax report addon for Wealthfolio (https://github.com/advenacodex/wealth-tax).
Merges main, removes the retired verification field, adds the commercial model, and drops the generated README hunk. Adds the derived record read from the publisher's repository, including the not-tax-advice notice its tags imply. Validation fails until the addon is rebuilt: the manifest declares SDK 3.0.0, which predates the sandbox, so nothing about where the addon sends data can be established from it.
|
Thanks for this, and sorry it sat so long. I introduced the addon sandbox in 3.6 and reworked how community listings work before getting to the queue, so your PR needed updating rather than just merging. I've pushed the changes to your branch:
You don't declare licence, compatibility, data handling or disclaimers any more. I read them from your repo: MIT, and your One thing is blocking it, and CI is red because of it: your manifest declares SDK 3.0.0. The directory needs 3.6 or newer. The reason isn't that old is bad. 3.6 added a sandbox, so an addon that doesn't ask for the network permission genuinely cannot reach the network. That lets the listing tell people "this addon keeps your data on your machine" and have it be true, because the runtime enforces it. Before 3.6 an addon could call out without declaring anything, so I can't say that about WealthTax, and I'd rather publish nothing than publish a guess. A rebuild against 3.7 fixes it and CI goes green. Fair warning that 3.0 to 3.7 may need more than a version bump: https://github.com/wealthfolio/wealthfolio/blob/main/docs/addons/addon-migration-guide-v2-to-v3.md Then post this as a comment and I'll merge: I have read POLICIES.md and confirm:
- [ ] I am the publisher of this addon, or authorised to act for them.
- [ ] I have the rights to the name and description, and grant Wealthfolio permission to display them.
- [ ] The repository is public and has a licence file.
- [ ] What I declared is accurate, and my manifest declares every host the addon reaches.
- [ ] There is no hidden data collection or undisclosed remote code.
- [ ] I own support, updates, security fixes, privacy, licensing, and commercial terms.
- [ ] The name doesn't imply the addon is official or endorsed.
- [ ] A listing is a link only. Wealthfolio doesn't host, audit, endorse, or support it, and may remove it. |
FIFO realized gains and open positions tax report addon for Wealthfolio (https://github.com/advenacodex/wealth-tax).