UI: Refactor Create Wizard Cards in Platform UI#1105
Open
rosalieper wants to merge 4 commits intomainfrom
Open
UI: Refactor Create Wizard Cards in Platform UI#1105rosalieper wants to merge 4 commits intomainfrom
rosalieper wants to merge 4 commits intomainfrom
Conversation
|
Deployment previews on netlify for branch
|
tarrow
requested changes
Mar 11, 2026
| @click="submitWholeForm" | ||
| > | ||
| {{ submitButtonText }} | ||
| Create Wiki |
Contributor
There was a problem hiding this comment.
This now needs to have a different value hardcoded because this component is now designed to be used in the ProfileEdit context. It should have "Set intended use" from https://github.com/wbstack/ui/pull/1105/changes#diff-65f4e79e86b49a3110f6196179d7d13de0b9d84e8cc5b8f42a42de0dbcb98273L24
rosalieper
changed the title
* Move `TemporalityProfileEditWizardStep` to where it is used in `Pages/ManageWiki/cards` * Remove `dissmissable` property from `TemporalityCreateWikiWizardStep` and the optional close-dialog icon that will never be displayed * Remove `dissmissable` property from `TemporalityProfileEditWizardStep` and the `v-if` logic for the close-dialog icon as that will always be displayed * Remove unused `buttonText` property from `CreateWiki`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TemporalityCreateWikiWizardStepcard (based on the existingStepThreeCard) for use only in the create wiki wizard.StepThreeCardtoTemporalityCreateWikiWizardStepTemporalityProfileEditWizardStepto where it is used inPages/ManageWiki/cardsas this is no long a component used in multiple parts of the codebasesubmitButtonTextabstraction logic from theTemporalityCreateWikiWizardStepandTemporalityProfileEditWizardStepcards. As they are no longer reused each card can hard code the correct value.dissmissableproperty fromTemporalityCreateWikiWizardStep, and the optional close-dialog icon that will never be displayeddissmissableproperty fromTemporalityProfileEditWizardStep, and thev-iflogic for the close-dialog icon as that will always be displayedbuttonTextproperty fromCreateWikiBug: T419207