Add BookingProject, ContactDetailsGroup and some other small features - #67
Add BookingProject, ContactDetailsGroup and some other small features#67Blumenkind111 wants to merge 19 commits into
Conversation
…rect handling of non ascii chars (f.e. '&') , including a test
|
I also noted, that invNumber has not to be required for InvoiceCreate. That makes it possible to let easyverein calculate the next invoice number. So I implemented that |
Sadly, there does not seem to be a way to do the group assignments via api
it is an undocumented feature ...
Blumenkind111
changed the title
waza-ari
left a comment
waza-ari
left a comment
There was a problem hiding this comment.
Hey @Blumenkind111 , my apologies for coming back so late. I've finally found the time to go through the PR. First of all, much appreciate your time and commitment adding those two endpoints!
Added a few comments in the review, only one somewhat "major". Would appreciate an update and rebase onto main, although there should be no breaking changes.
Also, let's update the docs folder for those new endpoints. Check the existing ones, most of that is auto-generated so it should be quite quick. Happy to merge afterwards!
| """ | ||
|
|
||
| pass | ||
| member: EasyVereinReference | Member | None = None |
There was a problem hiding this comment.
IIRC this is correct as contact details must exist before creating a member, therefore there's no point having that relationship in any other class. Just sanity check for myself, was that your rationale?
There was a problem hiding this comment.
Well if filtering ContactDetails based on if it is a member or not, it is quite useful and saves some traffic, so that we dont have to pull down every member :) In our specific case we have some contacts twice. Once for a member and once for payments they receive. Because the payment should go to another account than the one we pull our membership fees from ... :) This seemed like the most easy way to achieve that. And the Field is also provided by the API
- made the count initial state based. This is more robust, when the test db is corrupted (which mine often is) - Add Tests for closingDescription - modify test vor invNumber not needed
…for booking creation exclude_default instead of exclude_none in search serialization. Did not break any tests
# Conflicts: # easyverein/models/contact_details.py # tests/test_invoice.py
|
Hi, thanks for the thorough feedback 👍 I included the proposed changes and in the meantime added some more features. I also deleted everything in my branch while trying to update it. Not too familiar with git 😵 I am happy to do more changes if the code does not meet the project standard! I fixed all comments. Also did some actualization of the docs. The autogenerated part has been done by my bot, because i did not know how ... Together we also updated some outdated parts in the readme and global docs files. |
2 participants
I added the BookingProject to python-easyverein.
Also rewrote the url construction, that it may parse special letters like "&" correctly + some minor fixes
If needed i can update the docs, but cannot promise, i will get to it in time :)