This repository was archived by the owner on Nov 29, 2022. It is now read-only.
Update sim_pte to use specified covariance between predictors#39
Open
cody-somerville wants to merge 1 commit into
Open
Update sim_pte to use specified covariance between predictors#39cody-somerville wants to merge 1 commit into
cody-somerville wants to merge 1 commit into
Conversation
Implementation of sim_pte was not utilizing the value of the rho argument to generate covariance matrix for use with generating multivariate normal distribution sample. Updated sim_pte to match behavior of parent R implementation.
Author
|
@rsyi This change may interest you for your pylift/pylift fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of sim_pte was not utilizing the value of the rho argument to generate covariance matrix for use with generating multivariate normal distribution sample. Updated sim_pte to match behavior of parent R implementation.