usdr_dm_create: fix TX generator format check#111
Open
cvalentine99 wants to merge 1 commit intowavelet-lab:mainfrom
Open
usdr_dm_create: fix TX generator format check#111cvalentine99 wants to merge 1 commit intowavelet-lab:mainfrom
cvalentine99 wants to merge 1 commit intowavelet-lab:mainfrom
Conversation
TX sine generator thread selection compared fmt_rx instead of fmt_tx, selecting the wrong sample-generation path when RX and TX formats differ. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
usdr_dm_create.c, the TX sine generator thread selection (lines1149-1157) compares
fmt_rx(set by-F) instead offmt_tx(set by-i). The TX stream itself is correctly created withfmt_tx(line 1072),so when RX and TX formats differ, the TX generator can select the wrong
sample-generation path. The bug is latent when both formats match (the
default case). Also updates the error message to print
fmt_txandreference the TX format option.
Validation
-Fsetsfmt_rxand-isetsfmt_tx(lines 796-800)fmt_tx(line 1072)fmt_txconsistentlyBehavioral expectation
fmt_rx == fmt_tx(the default and most common usage)