feat: support arbitrary pointer literals and expand CLI build options #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the handling of pointer literals in the LLVM backend
and introduces new CLI capabilities for building object files and
executables.
Changes:
- **Pointer Literal Enhancements**:
- Relaxed the restriction on pointer literals. Previously, only `0`
was allowed as a null pointer.
- Now supports arbitrary numeric literals by parsing them as integers
and using `build_int_to_ptr` to cast them to the target pointer type.
- Added a panic check to prevent negative numeric literals from being
used as pointers.
- **CLI & Command Expansion**:
- **`run` command**: Added a `--img` flag to trigger an image-based
build-and-run flow.
- **`build` command**:
- Added a `-o` flag to compile source files into machine object
files (`.o`).
- The default build command now compiles and links files into a
final binary inside the `target/` directory.
- **Runner & Pipeline Refactoring**:
- Implemented `object_build_wave_file` to handle the full compilation
pipeline (lexing, parsing, IR generation, and object code emission)
with detailed debug support for tokens, AST, and hex dumps.
- Implemented `build_wave_file` to orchestrate the linking of
generated object files into executable binaries.
- **Library API**:
- Exported `compile_and_build` and `compile_and_build_obj` in `lib.rs`
to provide programmatic access to the new build workflows.
These changes provide more flexibility for system-level programming and
improve the developer experience when managing build artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly enhances the Wave compiler's system-level programming capabilities and matures its build system. By allowing arbitrary numeric values to be cast as pointers, developers can now interact with fixed memory addresses (essential for embedded or OS development). Additionally, the CLI has been expanded to support professional build workflows, including object file generation and linked executable creation.
Key Changes
1. Arbitrary Pointer Literals
0as a null pointer literal.build_int_to_ptrto safely cast them to the target pointer type.2. Expanded CLI & Build Commands
-oflag to thebuildcommand, allowing developers to compile Wave source files into machine-specific object files (.o).buildcommand now orchestrates the full pipeline—compiling to object code and then linking into a final binary stored in thetarget/directory.runFlag: Added the--imgflag to theruncommand to support specialized image-based build-and-run flows.3. Compilation Pipeline Refactoring
object_build_wave_fileandbuild_wave_fileto handle the multi-stage compilation process.compile_and_buildandcompile_and_build_objinlib.rs, enabling external tools or scripts to programmatically access Wave's build workflows.