Repository navigation
fix(sales): direct confirm-order sends once; in-Thailand stock lines need no lead time - #1185
Merged
waritctd merged 1 commit intoOct 28, 2026
Merged
Conversation
…iland stock lines need no import lead time (UI re-walk 2026-10-29) - SK-02/VW-05: the direct-quotation confirm dialogs (TicketDetailPage, QuotationEditorPage) close before mutating, like the pricing-request door, and call /confirm-order (the backend /promote-to-deal alias stays for one deploy). - VW-01: DealQuotationItemDto exposes stockSource; submit and the editor skip the import lead-time requirement for IN_THAILAND stock lines only. IN_TRANSIT and import lines still need one (owner ruling 2026-10-29). A copied quotation drops stockSource, as the server does. - API digests regenerated (response-fields: DealQuotationItemDto.stockSource; ui-reachable: confirm-order). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two leftovers from the 2026-10-29 UI re-walk of the PR #1182 fixes.
Changes
TicketDetailPageconfirmOrderDirect,QuotationEditorPage) now close before mutating, the same as the pricing-request route, so a second click does nothing. The call moves from thepromote-to-dealalias to/confirm-order(same handler). The backend alias stays for one deploy so a cached bundle still works.DealQuotationItemDtonow exposes the already-storedstock_source. Submit (requireEveryTileItemHasALeadTime) and the editor (quotationMeta.validateQuotationItem) skip the import lead-time requirement for IN_THAILAND lines only. IN_TRANSIT and import lines still need a lead time (owner ruling 2026-10-29). A copied quotation dropsstockSource, matching the server.response-fields.json(+DealQuotationItemDto.stockSource),ui-reachable.json(confirm-order replaces promote-to-deal).api-surface.jsonis unchanged.Test coverage (written first, each seen red before its fix; Opus reverted every hunk and saw its test go red)
QuotationEditorPage.promoteToDeal.test.jsxandTicketDetailPage.test.jsx. Two fast clicks on confirm call the API exactly once.serverContract.test.jspins the confirm-order URL.DealQuotationIntegrationTest#submit_inThailandStockLineNeedsNoLeadTime_butInTransitAndImportStillDo: an IN_THAILAND row with no lead time submits; an IN_TRANSIT or import row with no lead time is refused, naming only that row.quotationMeta.test.jsandQuotationEditorPage.v3.test.jsx: the same rule in the editor.quotationCopy.test.jsx: a copy carries nostockSource.Deliberately not covered: the pricing-request confirm route (it already sends once), the PDF lead-time remark for stock rows (unchanged; an in-Thailand line that has a lead time still prints it), and plain/adjustment rows (unchanged).
Known, not in this PR
/promote-to-dealalias can be removed in a later release, together withDealQuotationControllerTest:124and its SERVER_ONLY contract entry.stock_sourceis fixed when the row is inserted, so converting an in-transit line to import afterwards doesn't update an existing quotation.🤖 Generated with Claude Code