[waritctd]

Draft. Owner ruling (Ploy, 2026-10-23): sales can change the deposit % on the deposit notice and the amount recalculates automatically — on a DRAFT only; an issued notice is a customer document (409). This REVERSES the 2026-09-29 ruling that locked the % to the quotation. The % still defaults from the quotation at creation (creation paths untouched; #1170 reworks them). One deposit per deal stays (already enforced: issuing supersedes older ISSUED notices, DepositNoticeRepository:304, pinned by DepositNoticeIssueGuardIntegrationTest#issue_secondDraftOnSameTicketSucceedsAndSupersedesTheFirst).

Change

• DepositNoticeService#update: honours depositPercent on a draft (null keeps the stored one); refuses ≤ 0 ("เปอร์เซ็นต์มัดจำต้องมากกว่า 0") and non-whole percents ("เปอร์เซ็นต์มัดจำต้องเป็นจำนวนเต็ม") with 400; issued → 409 via requireDraft. @DecimalMax message now Thai ("เปอร์เซ็นต์มัดจำต้องไม่เกิน 100").
• DepositNoticeRepository#update: recomputes deposit/VAT/total from the new percent; latent bug fixed: an update without items (null or []) used to zero the subtotal and amount while keeping the rows — it now sums the stored rows.
• DepositNoticePage.jsx: enabled whole-number % field on a draft (typed value rounded), live recalculation, sends depositPercent; read-only once issued; cleared field shows ฿0 (was a silent 50%).
• Mock depositNotices.update mirrors draft/issued/zero/fractional/over-100 rules. Stale "locked" comments rewritten.

Test-first (each test commit precedes its fix commit; RED quotes)

Test	Pins	Red before
DepositNoticeServiceTest#update_onADraft_persistsTheCallersDepositPercent (revised from the old "ignoring caller value" pin)	0.40 reaches the repository	expected: 0.40 but was: 0.50
…#update_withNoDepositPercent_keepsTheDraftsStoredPercent	null keeps 0.50	guard (green before)
…#update_refusesAZeroOrFractionalDepositPercent_andWritesNothing	0 and 0.405 → 400, nothing written	Expecting code to raise a throwable
DepositNoticeControllerTest#updateRejectsADepositPercentOver100WithAThaiMessage	1.5 → Thai message	English message
DepositNoticeIssueGuardIntegrationTest#update_onADraft_changesThePercentAndTheAmountFollows (real DB)	DTO 0.40 / 40.00 / VAT 2.80 / 42.80; preview "ขอรับเงินมัดจำ (40%)"; then 0.30 with items=null and 0.20 with items=[] keep the rows and recompute	expected: 0.40 but was: 0.5000; :261 expected: 100.00 but was: 0.00
…#update_onAnIssuedNotice_refusesThePercentEditWith409_rowUnchanged	409, status/percent/amount/items unchanged	guard
DepositNoticePage.test.jsx "lets sales change the deposit percent on a draft…" (revised from the read-only-label test)	field enabled, 39.6 → 40, (40%) / 200.00 / 214.00, saves 0.4; cleared → 0.00	Unable to find a label … % มัดจำ; 200.00 บาท (billed 198.00)
… "shows the deposit percent read-only once the notice is issued"	disabled, shows 30	—
mockApi.depositNotices.test.js update cases (revised)	draft takes 0.4 and recomputes; 0 / 1.5 / 0.405 refused; issued → 409	promise resolved … instead of rejecting

Mutations (implementer 10 + reviewer 5), each killed by a named test: override restored; draft check removed; amount not recomputed; VAT/total stale; zero allowed; whole-number check off; Thai message off; page rounding off; || 0.5 fallback restored; field always disabled; page sends ×100; mock checks off; stored-rows sum replaced by empty stream.

Not covered: decimal input beyond rounding (field is whole-number); concurrent updates (pre-existing DELETE/INSERT race); the creation paths (#1170).

Opus review (2026-10-23): APPROVE WITH NOTES — all notes applied

Medium (fractional % → mismatched document) fixed in ce592248. Checked OK by reading: remaining invoice (DepositNoticeService:689/736), confirmDepositPaid (TicketService:978), finance view and PDF all read the stored amounts of the ISSUED notice; rounding matches createDraft; no caller sends [] meaning "clear"; complements #1173's issue guards.

Behaviour changes to note: a draft stored at 0% (legacy route) now gets 400 on save until the % is raised (consistent with "0% = no deposit stage"). Pre-existing, left alone: requireDraft runs before the owner check on update (same as issue()); item DELETE/INSERT race.

Merge-tree clean vs develop, #1168, #1170, #1173.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UXmTJDVga17Rn5az4YBjZ2

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
demo-glr	Ready	Preview	Oct 27, 2026 9:08pm UTC

[waritctd]

/code-review max (head ce59224): 10 finders → 22 unique candidates → 21 confirmed / 1 plausible, + 5 from the sweep. Verdict: do NOT merge yet. Items 1, 6–12, 14, 15 are fixable here; 2, 4, 5 need an owner ruling. Full verdicts in the session scratchpad review-1176/.

Money / document correctness

1. (PR-introduced) DepositNoticeService:166 the >0 rule lives only in update(). A 0% DEAL_DIRECT quotation (ไม่รับมัดจำ) still mints a 0.00 draft via the ticket route; the editor's only exit is typing a non-zero % → issue() re-checks neither percent nor amount → a deposit is issued against a no-deposit quotation (impossible on base). Fix at the choke points: refuse a 0% source in createDraftFromQuotation (mirror OrderConfirmationService:483) and require 0 < % ≤ 1 and amount > 0 in issue().
2. (owner call) DepositNoticeService:142 re-creating a draft re-seeds the % from the quotation; on a PCR deal the create button stays visible after a 40% notice is ISSUED, so a re-create + issue silently supersedes the customer's 40% document with a 30% one. Fix: seed from the latest ISSUED notice, or block/warn when one exists.
3. DepositNoticePage.jsx:461/468 the || 0 fix on the % was not applied to the identical netUnitPrice || unitPrice || 0 on line net prices: a 100%-discounted line is summed and SAVED at its unit price by the first PUT, which editing the % now requires. ?? as lines 766/770 already do.
4. (owner call, pre-existing) DepositNoticeRepository:430 findDealQuotationItems copies DEAL_DIRECT ADJUSTMENT rows (qty −1) into the draft; @PositiveOrZero qty then rejects every PUT from the page → on any deal with ส่วนลดพิเศษ nothing in the editor saves and the % edit is unreachable. Fold the adjustment into goods lines, or allow signed qty end-to-end.
5. (owner call, pre-existing) DealDepositPanel.jsx:159 one-click ออกเอกสาร with no confirm and no baht amounts; no re-version/void for an ISSUED notice. A saved typo (3 for 30) becomes a permanent numbered document. ConfirmDialog with amounts + a re-version path.
6. (PR-introduced) DepositNoticeService:165 the removed override was the only stale-request protection: two tabs on one draft, B saves after A changed the % → B's old % and amounts win silently (page reseeds only on id:version:status; version never changes). Pattern exists: LeadTimeChangeRepository:113 AND version = :expectedVersion.
7. DepositNoticeRepository:244 update() ignores the header UPDATE row count (WHERE status='DRAFT') and then runs item DELETE/INSERT unguarded → a save racing issue() rewrites the ISSUED notice's lines behind a 200, and the PDF/XLSX totals are template formulas over the rows (not reads of the stored amounts, as the Opus note said). Check the count → 409 before touching items.

Validation / UX
8. DepositNoticePage.jsx:452 a cleared % sends 0 → 400 rejects the WHOLE PUT incl. customer/item edits (page contract says partial saves must work). Send null for '' or validate client-side; filter blank เพิ่มรายการ rows.
9. DepositNoticePage.jsx:103 validateIssueForm never sees the %: 0/negative blames unit price/qty; 150% passes the gate, opens the confirm dialog, then fails with an English-prefixed toast and the dialog stays open. Add a whole 1–100 rule with its own message.
10. DepositNoticeService:170 whole-number check runs on the echoed stored value: a draft stored at 0.3330 (pre-09-29 free input) shows 33 but 400s on every save. Skip when req == doc or round in populateForm; enforce in issue() too.
11. DepositNoticeDraftRequest:16 one rule over four mechanisms; @DecimalMin("0") still English for −5. @DecimalMin(value="0", inclusive=false, message="เปอร์เซ็นต์มัดจำต้องมากกว่า 0") (idiom: ThicknessDefaultRequests:28).
12. DepositNoticeService:161 update() has no requireRole(SALES_ROLES) while create/issue do; a grant-revoked or promoted owner can still PUT 100%. Add the role gate; fix the stale "sales_manager can never own a ticket" comments in the test.
13. mockApi.js:13347 mock update: checks run after 404/409 (backend @Valid runs first), skips >0 on the stored value, no owner check on update/issue.
14. DepositNoticeIssueGuardIntegrationTest:306 the stored-lines branch is tested with one line qty 1 unit=net=amount=100 (cannot tell net×qty from unit×qty or SUM(amount)); mock reread weakened in 50b2bd6; "cleared field bills 0" assertions sit after a line that goes red first so never ran red; two mock its labelled "(revised)" are new.
15. Cleanup DepositNoticeRepository:213 dead null → 0.50 fallback; comments claiming "defaults from the quotation" are false for a NULL-% quotation (#1170's area); page money math drops per-step HALF_UP (฿0.01 drift in the summary/confirm dialog); findItems re-reads rows already held.

Cut at the 15-cap (pre-existing): PricingRequestDetailPage 0–1 "% มัดจำ" input discarded (typing 40 → English 400); header-subtotal/row precision for 4-dp quantities.