fix(sales): the deposit notice bills what the customer's latest answered quotation printed (blank new-engine % = 30, legacy = 50, one row for lines and %) by waritctd · Pull Request #1170 · waritctd/GL-R-ERP

test(sales): pin that a null-percent quotation's deposit notice bills the PDF's 30%

waritctd

and

claude

committed

8d068d0

fix(sales): blank deposit percent on a new-engine quotation bills the 30% the PDF prints

waritctd

and

claude

committed

32f4e87

test(sales): pin that a live legacy quotation bills its PDF's 50%, not a sibling new-engine 30%

waritctd

and

claude

committed

6b5a697

fix(sales): a live legacy quotation bills the 50% its PDF prints, never a sibling new-engine percent

waritctd

and

claude

committed

a33a80e

docs(sales): firstOrNull Javadoc no longer describes a null the queries cannot return

waritctd

and

claude

committed

c8807ee

test(sales): fold the null-percent deposit cases into the existing route tests and pin the quotation's own percent

waritctd

and

claude

committed

0762fd2

test(sales): pin that the ticket-route deposit notice follows the latest answered quotation, lines and percent from one row (RED)

waritctd

and

claude

committed

16ca96f

fix(sales): the deposit notice follows the latest quotation the customer answered, lines and percent from one row

waritctd

and

claude

committed

c0d840c

test(sales): pin that a ticket-level legacy quotation never governs the deposit notice

waritctd

and

claude

committed

b26f09a

docs(sales): name the ACCEPTED-then-DEAL_DIRECT case where the deal page and the deposit pick differ

waritctd

and

claude

committed

3fb6385

test(sales): a 0% governing quotation is refused on the ticket route too

waritctd

and

claude

committed

2b167d6

fix(sales): refuse a 0% governing quotation on the ticket-route deposit draft

waritctd

and

claude

committed

f56d4a0

test(sales): approved_price lines do not take the governing quotation's number as reference

waritctd

and

claude

committed

4e8187c

fix(sales): default the deposit reference only when the lines came from the governing quotation

waritctd

and

claude

committed

22d4488

test(sales): governing-quotation fixtures that only the ranking, not insertion order, can satisfy

waritctd

and

claude

committed

8691a87

test(sales): mock deposit fixture at 40% and a ticket-route set-percent case

waritctd

and

claude

committed

bd6255c

test(sales): the PR page's deposit button shows no "% มัดจำ" input and sends no percent

waritctd

and

claude

committed

ef56053

fix(sales): delete the dead "% มัดจำ" input on the pricing-request page

waritctd

and

claude

committed

e8dd542

docs(sales): deposit-percent comments state the rule the code follows

waritctd

and

claude

committed

9a586ee

test(sales): pin that caller-supplied lines leave the mock deposit reference blank

waritctd

and

claude

committed

be22496

test(sales): mock deposit tie-break across both quotation arrays (RED)

waritctd

and

claude

committed

3bff49a

fix(sales): one mock quotation id sequence, so the deposit pick's "latest" spans both engines

waritctd

and

claude

committed

7a31851

test(sales): the Java deposit-constant guard ignores commented-out declarations

waritctd

and

claude

committed

c2fc558

test(sales): a PRICING_REQUEST quotation is never live as APPROVED in the deposit pick (RED)

waritctd

and

claude

committed

e1bc8ab

fix(sales): APPROVED counts as live only on a DEAL_DIRECT quotation in the deposit pick

waritctd

and

claude

committed

01ced6b

docs(sales): correct three deposit comments and move a misplaced one

waritctd

and

claude

committed

6becc08

test(sales): delete deposit tests the repository and parameterised tests already pin

waritctd

and

claude

committed

49f1762

docs(sales): name the shared mock quotation id counter in a pricing-request test comment

waritctd

and

claude

committed

eb15c14

docs(sales): the autofill test Javadoc no longer claims the repository test pins every status

waritctd

and

claude

committed

91b43d1

test(sales): pin every non-live (origin, status) pair and newer-ACCEPTED-beats-older-APPROVED ranking

waritctd

and

claude

committed

2280d34

docs(sales): move the DEAL_DIRECT-revision case to findGoverningQuotation; fix its ACCEPTED contradiction (no test: comment-only)

waritctd

and

claude

committed

407e9b1

fix(sales): mock deposit reference is null when the caller supplies the lines; reuse isDealDirectOrigin; seed id bump beside the seeds; test tidy-ups

waritctd

and

claude

committed

97cd8d1

Navigation Menu

Repository navigation

fix(sales): the deposit notice bills what the customer's latest answered quotation printed (blank new-engine % = 30, legacy = 50, one row for lines and %) - #1170

fix(sales): the deposit notice bills what the customer's latest answered quotation printed (blank new-engine % = 30, legacy = 50, one row for lines and %)#1170
waritctd merged 32 commits into
developfrom
fix/deposit-null-percent-matches-pdf

Commits on Oct 27, 2026

test(sales): pin that a null-percent quotation's deposit notice bills the PDF's 30%

fix(sales): blank deposit percent on a new-engine quotation bills the 30% the PDF prints

test(sales): pin that a live legacy quotation bills its PDF's 50%, not a sibling new-engine 30%

fix(sales): a live legacy quotation bills the 50% its PDF prints, never a sibling new-engine percent

docs(sales): firstOrNull Javadoc no longer describes a null the queries cannot return

test(sales): fold the null-percent deposit cases into the existing route tests and pin the quotation's own percent

test(sales): pin that the ticket-route deposit notice follows the latest answered quotation, lines and percent from one row (RED)

fix(sales): the deposit notice follows the latest quotation the customer answered, lines and percent from one row

test(sales): pin that a ticket-level legacy quotation never governs the deposit notice

docs(sales): name the ACCEPTED-then-DEAL_DIRECT case where the deal page and the deposit pick differ

test(sales): a 0% governing quotation is refused on the ticket route too

fix(sales): refuse a 0% governing quotation on the ticket-route deposit draft

test(sales): approved_price lines do not take the governing quotation's number as reference

fix(sales): default the deposit reference only when the lines came from the governing quotation

test(sales): governing-quotation fixtures that only the ranking, not insertion order, can satisfy

test(sales): mock deposit fixture at 40% and a ticket-route set-percent case

test(sales): the PR page's deposit button shows no "% มัดจำ" input and sends no percent

fix(sales): delete the dead "% มัดจำ" input on the pricing-request page

docs(sales): deposit-percent comments state the rule the code follows

test(sales): pin that caller-supplied lines leave the mock deposit reference blank

test(sales): mock deposit tie-break across both quotation arrays (RED)

fix(sales): one mock quotation id sequence, so the deposit pick's "latest" spans both engines

test(sales): the Java deposit-constant guard ignores commented-out declarations

test(sales): a PRICING_REQUEST quotation is never live as APPROVED in the deposit pick (RED)

fix(sales): APPROVED counts as live only on a DEAL_DIRECT quotation in the deposit pick

docs(sales): correct three deposit comments and move a misplaced one

test(sales): delete deposit tests the repository and parameterised tests already pin

docs(sales): name the shared mock quotation id counter in a pricing-request test comment

docs(sales): the autofill test Javadoc no longer claims the repository test pins every status

test(sales): pin every non-live (origin, status) pair and newer-ACCEPTED-beats-older-APPROVED ranking

docs(sales): move the DEAL_DIRECT-revision case to findGoverningQuotation; fix its ACCEPTED contradiction (no test: comment-only)

fix(sales): mock deposit reference is null when the caller supplies the lines; reuse isDealDirectOrigin; seed id bump beside the seeds; test tidy-ups