Skip to content

Keep activity log lines whole across output segments - #40

Merged
WarheadTaylor merged 1 commit into
masterfrom
fix/activity-log-formatting
Oct 19, 2026
Merged

WarheadTaylor merged 1 commit into
masterfrom
fix/activity-log-formatting

Conversation

@WarheadTaylor

Copy link
Copy Markdown
Member

Summary

  • Activity log output segments now close only after a newline, so a log line is no longer split across rows when a chunk ends mid-line.
  • A segment can grow past the 4 KiB target (up to a new 16 KiB hard cap) to finish its current line. A single line longer than the cap still splits mid-line.
  • Continuation segments skip the stream label (cmd/sys/stdout/stderr), since they continue the previous segment's stream.
  • The segment-building logic moves into a nextSegmentText helper.

Testing

  • Added a test that feeds 500 build-style lines in uneven 37-character chunks and checks that every closed segment ends in a newline, that continuations are marked, and that the joined raw text matches the input.
  • Added a test that a line under the hard cap stays whole, and that a line over the cap splits at exactly ACTIVITY_LOG_SEGMENT_MAX_CHARS.
  • Updated the existing segment-bounds assertion to use the new cap constant.
  • Not run: vp check, vp run typecheck, and the activityLog test suite. Run them before merging.
  • Not run: visual verification of the activity log in Electron (npm run dev:inspect). Label and wrapping behavior has not been checked on screen.

- Close output segments only at newline boundaries, letting a segment grow past 4 KiB (up to 16 KiB) to finish its last line
- Split a line mid-way only when it exceeds the 16 KiB hard cap
- Omit the stream label on continuation segments so the same stream isn't labeled twice
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-19T08:02:56.696973Z 541ce5b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@WarheadTaylor
WarheadTaylor merged commit 57b7e75 into master Oct 19, 2026
6 checks passed
@WarheadTaylor
WarheadTaylor deleted the fix/activity-log-formatting branch October 19, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant