Skip to content

Enhance audit summaries with message text - #56

Closed
TheoExall wants to merge 1 commit into
warcon-app:mainfrom
TheoExall:main
Closed

TheoExall wants to merge 1 commit into
warcon-app:mainfrom
TheoExall:main

Conversation

@TheoExall

Copy link
Copy Markdown

The problem

Manual whisper audit entries and Discord command notifications showed the delivery result but omitted the message text, making it difficult for staff to review what was sent.

The change

  • Include message text alongside delivery results for manual single-player and group whispers.
  • Redact credential-looking lines before storing or forwarding the summary.
  • Preserve the full whisper within the existing 1,000-character audit summary limit.
  • Document the behaviour.

Things worth your view

  • Only new audit entries include whisper text; historical entries remain unchanged.
  • Automated whispers remain private and continue to record only their short result.
  • Discord messages retain existing escaping for formatting, mentions and links.
  • Other action summaries remain unchanged.

Tests

Added coverage for:

  • Single-player and group whispers, including failed and partial delivery.
  • Message length limits and long delivery results.
  • Credential redaction.
  • Missing, empty and malformed message text.
  • Automated messages and unrelated actions remaining unchanged.
  • Discord escaping and preservation of the full whisper text.

Checks

  • No dependency or database schema changes.

@TheoExall TheoExall changed the title Enhance audit summaries with message text and credential redaction Enhance audit summaries with message text Oct 24, 2026
@TheoExall TheoExall closed this Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant