feat(weave): enable server side sorting#6512
Closed
nikumar1206 wants to merge 4 commits intomasterfrom
Closed
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=5816aa47768f0ef9fe4f3e1573fda4332dc6d10e |
neutralino1
reviewed
Mar 31, 2026
Collaborator
neutralino1
left a comment
neutralino1
left a comment
There was a problem hiding this comment.
What advantage does this bring compared to client-side sorting?
I understand this would be a requirement for server-side pagination but that is not enabled yet.
Contributor
Author
|
server-side sorting is a pre-req for server-side pagination. if we implement pagination first, the client side would be sorting items from just one page of data, which would break the current functionality we already have on the frontend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables server-side sorting for evaluation results. We now take a 'sort_by' parameter in the API endpoint, and the sort_by is resolved in Python. We can push this into CH later if we would like!
Testing