chore(weave): add migration-lock table for ch replicated migrations#6511
Open
gtarpenning wants to merge 10 commits intomasterfrom
Open
chore(weave): add migration-lock table for ch replicated migrations#6511gtarpenning wants to merge 10 commits intomasterfrom
gtarpenning wants to merge 10 commits intomasterfrom
Conversation
gtarpenning
changed the title
gtarpenning
changed the base branch from
griffin/fix-altinity-replicated-operator-migration
to
master
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=2d839249d944100ce1df1a780ff8ab32a09430ca |
HiveMind Sessions8 sessions · 1h 56m · $26
View all sessions in HiveMind → Run |
amwarrier
approved these changes
Mar 30, 2026
neutralino1
approved these changes
Apr 2, 2026
…ce consistent read, replace legacy mocks
…se assertions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sticky connection (same ch_client for insert + verify) already guarantees we read our own writes. Idempotent DDL is the ultimate safety net. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gtarpenning
force-pushed
the
griffin/migration-lock-table
branch
from
f5fb781 to
982f123
Compare
- Retry try_acquire on OperationalError during acquire_with_retry, so init-container startup races tolerate brief connection blips. - Surface persistent transient failures as MigrationLockError (same code path as the "lock held too long" timeout) instead of raw driver errors. - Fix docstring wording (typos hook was tripping on "INSERTs"). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a distributed migration lock so that only one replica runs ClickHouse migrations at a time in multi-replica deployments (1S2R, 2S2R, etc).
https://coreweave.atlassian.net/browse/WB-32669
migration_lock.pymodule: insert-then-verify advisory lock backed by a MergeTree table with TTL expiryapply_migrationsnow acquires the lock before running, releases on exit