feat(weave): write explicit 'latest' alias on every obj_create (WB-32435)#6481
Closed
rgao-coreweave wants to merge 10 commits intomasterfrom
Closed
feat(weave): write explicit 'latest' alias on every obj_create (WB-32435)#6481rgao-coreweave wants to merge 10 commits intomasterfrom
rgao-coreweave wants to merge 10 commits intomasterfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f788d7eadc800ae0308cc294718ab8dee7a1ffc7 |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Contributor
Author
Code reviewFound 1 issue:
weave/weave/trace_server/sqlite_trace_server.py Lines 4759 to 4762 in 054b8ed |
Contributor
|
This PR has been inactive for 14 days. It will be closed in 7 days unless there is new activity. |
Contributor
|
Closing this PR due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
obj_create, so re-publishing old content promotes it to "latest" — matching W&B Artifacts behavior_maybe_resolve_aliasto resolve "latest" from the aliases table first, falling back to computedis_latestfor legacy objectsis_latestChanges
obj_create: calls_insert_aliases("latest")after every insert_maybe_resolve_alias: resolves "latest" from aliases table with_resolve_computed_latestfallback_enrich_objs_with_tags_and_aliases: only synthesizes "latest" fromis_latestfor objects without an explicit alias rowadd_aliases_condition: includes "latest" in alias subquery alongsideis_latest = 1OR fallbackobj_create: writes "latest" alias in both dedup and new-insert pathsTest plan
test_obj_create_writes_latest_alias— verifies alias is writtentest_obj_create_moves_latest_alias_on_new_version— alias moves on new versiontest_obj_create_moves_latest_alias_on_dedup— alias moves on re-publish (dedup)test_resolve_latest_falls_back_to_computed— legacy objects without alias still worktest_resolve_computed_latest_returns_none_for_missing— nonexistent object returns None