Conversation
ngrayluna
requested review from
johndmulhausen
and
a lite review from Copilot
September 22, 2026 20:20
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed workflows consistently pin the compatible dependency version.
Review effort: Lite
Findings: None
What changed in this PR
Pins fastcore below v2 to preserve compatibility with fastcore.script.Param.
Changes:
- Adds
fastcore<2to PR reply workflows. - Adds
fastcore<2to notebook cleanup dependencies.
| File | Description |
|---|---|
.github/workflows/pr_reply2.yml |
Pins compatible fastcore for PR replies. |
.github/workflows/pr_reply1.yml |
Pins compatible fastcore for notebook processing. |
.github/workflows/cleanup.yml |
Pins compatible fastcore for notebook cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
johndmulhausen
approved these changes
Sep 23, 2026
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "<a href=\"https://colab.research.google.com/github/wandb/examples/blob/main/colabs/intro/run_quickstart.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>\n" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Param class was removed from fastcore.script in fastcore v2. This PR pins the version we need.