Skip to content

Feat/mac dock bounce on flash - #5921

Open
julianstorer wants to merge 2 commits into
wailsapp:masterfrom
juggler-ai:feat/mac-dock-bounce-on-flash
Open

Feat/mac dock bounce on flash#5921
julianstorer wants to merge 2 commits into
wailsapp:masterfrom
juggler-ai:feat/mac-dock-bounce-on-flash

Conversation

@julianstorer

@julianstorer julianstorer commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

This gives Window.Flash a macOS implementation.

It currently flashes the taskbar button on Windows and is a documented no-op elsewhere. On macOS this makes it bounce the application's Dock icon to request the user's attention.

Summary by CodeRabbit

  • New Features
    • Added macOS Dock bounce notifications when window attention is requested.
    • Updated window flashing behavior documentation to clarify platform-specific behavior, including Windows taskbar flashing, macOS Dock bouncing, and Linux no-op behavior.

Flash was Windows-only (it flashes the taskbar button) and a no-op on macOS.
Wire it up on darwin via [NSApp requestUserAttention:NSInformationalRequest],
which bounces the app's Dock icon once to draw the user back to a window that
needs attention. The request completes on its own, so disabling is a no-op.
The Flash doc comment is updated to describe the per-platform behaviour:
taskbar button on Windows, Dock bounce on macOS, no-op on Linux.
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c24ba1f-9af3-4b9c-9fc5-448b12fc6755

📥 Commits

Reviewing files that changed from the base of the PR and between f80dad5 and 50587cb.

📒 Files selected for processing (2)
  • v3/pkg/application/webview_window.go
  • v3/pkg/application/webview_window_darwin.go

Walkthrough

The Flash documentation now covers Windows, macOS, and Linux. The macOS implementation requests an informational Dock bounce when flashing is enabled.

Changes

Window flash behavior

Layer / File(s) Summary
Cross-platform documentation and macOS Dock behavior
v3/pkg/application/webview_window.go, v3/pkg/application/webview_window_darwin.go
The Flash documentation describes Windows taskbar flashing, macOS Dock bouncing, and Linux no-op behavior. macOS forwards enabled requests to a native helper that requests one informational Dock bounce. Disabled requests remain inactive.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: v3-alpha

Suggested reviewers: leaanthony, taliesin-ai

Poem

A rabbit taps the Dock with glee,
One bounce for macOS to see.
Windows flashes, Linux rests,
Clear docs now describe the quests.
“Hop approved!” the rabbit sings.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description summarizes the feature but omits the required issue link, change type, test results, test configuration, and checklist details. Complete the template with the issue or WEP link, selected change type, test results and configuration, dependencies, and checklist confirmations.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the macOS Dock bounce implementation for Window.Flash, which is the primary change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant