Feat/mac dock bounce on flash - #5921
Conversation
Flash was Windows-only (it flashes the taskbar button) and a no-op on macOS. Wire it up on darwin via [NSApp requestUserAttention:NSInformationalRequest], which bounces the app's Dock icon once to draw the user back to a window that needs attention. The request completes on its own, so disabling is a no-op. The Flash doc comment is updated to describe the per-platform behaviour: taskbar button on Windows, Dock bounce on macOS, no-op on Linux.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe ChangesWindow flash behavior
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This gives
Window.Flasha macOS implementation.It currently flashes the taskbar button on Windows and is a documented no-op elsewhere. On macOS this makes it bounce the application's Dock icon to request the user's attention.
Summary by CodeRabbit